Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXwsR-0006In-86 for pgsql-hackers@arkaria.postgresql.org; Sat, 26 Mar 2022 03:14:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nXwsO-0002yM-Su for pgsql-hackers@arkaria.postgresql.org; Sat, 26 Mar 2022 03:14:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXwsO-0002yD-DF for pgsql-hackers@lists.postgresql.org; Sat, 26 Mar 2022 03:14:04 +0000 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nXwsG-00014U-BE for pgsql-hackers@lists.postgresql.org; Sat, 26 Mar 2022 03:14:03 +0000 Received: by mail-io1-xd32.google.com with SMTP id b16so11037895ioz.3 for ; Fri, 25 Mar 2022 20:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=P8DuHVR9sx6VR7ZVyiUS8bLrlcT30k+WB4Rpn9c9jeE=; b=KZw/bEsn+cRMA3aU4HlslZU5iVHzQBSibR5Ow+R3bO5UKxE9vwIZSYFo1zc2cUR7wQ svey5m6JRgxeA1oksjdIyDI6EazBHi663skKdKgBKH8kwYW5TFG/LogDXjrhNlnwBB2m FwNf5ZDhaInKDwAig7Kk1x4tKJYN1VIu49n5f+GPb357Mj2QnUHj0/Cp+dBJqvnRry1U neo9/buwTymgmBJQuL85yUp5nKb7NjXdSp+M4DGq5hBiaMy3KwQ3/6Xk1cXk5l6TZhWY FzxXENZseFWACW+pwTpaQW85OhNjRJDa4CE/h55mEX59rCYs/P0sPpDRzFRL1t8MOU7m N8aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=P8DuHVR9sx6VR7ZVyiUS8bLrlcT30k+WB4Rpn9c9jeE=; b=Jdjxjijs1DokTe/YDaKfxRJwKNbVF0OunsbzmPYW7TyxvKhIsCDVWyQatk16sL2RpR tqAh5oAfIsd6TCsXINVN++Sh1JnhM7sZq0p0KWT2M51rJd281NB7VAnZZaroExV0eTAn jJgp1upFEZpBDoyT4FJu1SfXVznaxBWQ7c3zQJKKFHOiIMEQDCNYfNdwd4iCR0FgeflX SHth2B8iBebFnaQ8X+uWvtPfhTPiB+gc2XMg3lLDyzAFe+O+jGyMYMcgX9KKAPlTYkFm 0SY7igOoLqZmn+1zkpp04HPW9iF5wkUg+q/eMb3hHwllZSLzAHGu+JzwMrlRexa8PnOh K1wQ== X-Gm-Message-State: AOAM531+pMwV/CFuws3c7ysBE/Uh6xoSptlQSwgeKnjAKQqwGA6jxjKg cA6WQSsnPMZfJGiuezE2ny3tnw== X-Google-Smtp-Source: ABdhPJxZfxZDuYX3+HBPk1gWOqeS9GoyPax+eWprOGwh7OdC+JPMcMRdGCaR8HUlXwt9PvMsRgE6Jg== X-Received: by 2002:a05:6638:1694:b0:31a:594:f4c7 with SMTP id f20-20020a056638169400b0031a0594f4c7mr7144760jat.139.1648264434267; Fri, 25 Mar 2022 20:13:54 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id d16-20020a92d790000000b002c8854c2779sm1843820iln.13.2022.03.25.20.13.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Mar 2022 20:13:53 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 45966800DBA; Fri, 25 Mar 2022 22:13:53 -0500 (CDT) Date: Fri, 25 Mar 2022 22:13:53 -0500 From: Justin Pryzby To: Andres Freund Cc: Robert Haas , pgsql-hackers@lists.postgresql.org, Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. Message-ID: <20220326031353.GG28503@telsasoft.com> References: <20220315190428.2xf6klawmaq4nuyy@alap3.anarazel.de> <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> <20220325212707.fkevorahowgur5ux@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220325212707.fkevorahowgur5ux@alap3.anarazel.de> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Mar 25, 2022 at 02:27:07PM -0700, Andres Freund wrote: > On 2022-03-25 13:52:11 -0400, Robert Haas wrote: > > On Fri, Mar 25, 2022 at 12:36 PM Andres Freund wrote: > > > Create a CF entry for it, or enable CI on a github repo? > > > > I created a CF entry for it. Then I had to try to Google around to > > find the URL from the cfbot, because it's not even linked from > > commitfest.postgresql.org for some reason. #blamemagnus I see it here (and in cfbot), although I'm not sure how you created a new patch for the active CF, and not for the next CF. https://commitfest.postgresql.org/37/ > > I don't think that the Windows CI is running the TAP tests for > > contrib. At least, I can't find any indication of it in the output. So > > it doesn't really help to assess how portable this test is, unless I'm > > missing something. > > Yea. It's really unfortunate how vcregress.pl makes it hard to run all > tests. And we're kind of stuck finding a way forward. It's easy enough to work > around for individual tests by just adding them to the test file (like Thomas > did nearby), but clearly that doesn't scale. Andrew wasn't happy with > additional vcregress commands. The fact that vcregress doesn't run tests in > parallel makes things take forever. And so it goes on. I have a patch to add alltaptests target to vcregress. But I don't recall hearing any objection to new targets until now. https://github.com/justinpryzby/postgres/runs/5174877506