Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYCCJ-0004j8-33 for pgsql-hackers@arkaria.postgresql.org; Sat, 26 Mar 2022 19:35:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nYCCH-0005ZN-AV for pgsql-hackers@arkaria.postgresql.org; Sat, 26 Mar 2022 19:35:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYCCH-0005ZA-1E for pgsql-hackers@lists.postgresql.org; Sat, 26 Mar 2022 19:35:37 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYCCA-0007Pt-IM for pgsql-hackers@lists.postgresql.org; Sat, 26 Mar 2022 19:35:36 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id BC74C5C00D5; Sat, 26 Mar 2022 15:35:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 26 Mar 2022 15:35:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=/t8wBIUVfGBpXXMOLe5HIZJdBWwqPLWtQla+6z HAKE4=; b=jNsrRI9D8I2RgzZdy4tfxV3vfMAyqsqqt5eNPTNLqiKKs6yqN9FRCV 5Ux0kZZHwSeuuy40G3v+4diJO8NSy8RRW8u1BybU49GkFwtgMAMTVCQXacVc1XQG /Vn/8v2ddoFYik19aTZ3H8PK0UcRtDplNCTFyWsf9mf4g/tMALV6Ln+3KgAC6Ptr Tpc7lDIEN6y89H9xPSlZZp6iCsSegFyNdiV52mU9HMKHFh+Q2iKD/ZwZFOKv1P9a eKgeaREuynxNl+GgLA3KMLlHFwNf86JTGYmyn4SBpVDt+dcDCSdfwe6bzGX73uu0 IoLfpvNUplUmkPW7uKmjayuD+8Pol0qA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=/t8wBIUVfGBpXXMOL e5HIZJdBWwqPLWtQla+6zHAKE4=; b=c1q8tW45mHLBMyO0ilI77yU0ICZX73iZ3 QJM3xpz6NZUmSD1RLXa5bokXto9GdpTQpjB37TKvpN3KkL+OPUvk6q6RtXdyg3Kr F2mjhIsztmSYCfL/6JOvM2scjTP1DsPKJysQ1RNVtyQHDVy8xHbjgrC2gT8pUY+8 h/F7HchFyldmk3saO/7qugJjF56ULGFucDnInG2UAy1Q+POfWQclmOnM9CFwhINZ vmAZmJGjflEMRUFJqzOo3BwLxyEQxtwDFuP85dWr2aDdj6eXQYByJfSi+PJu4LJD C1ap7tQEoc3h1apqJUhgZFWjnZSDhdMBSddDfov33IbulLzKTyoqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehfedguddvlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepudekhfekleeugeevteehleffffejgeelueduleeffeeutdelffeujeff hfeuffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 26 Mar 2022 15:35:29 -0400 (EDT) Date: Sat, 26 Mar 2022 12:35:28 -0700 From: Andres Freund To: Robert Haas Cc: Andrew Dunstan , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. Message-ID: <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> References: <20220315190428.2xf6klawmaq4nuyy@alap3.anarazel.de> <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-03-26 14:40:06 -0400, Robert Haas wrote: > Well, I think that's unwarranted. Many years ago, people discovered > that it was annoying if you had to distinguish files solely based on > name, and so they invented directories and pathnames. That was a good > call. Yea. I have no problem naming tests the same way, particularly if they do similar things. But we should show the path. > Displaying that information in the buildfarm output would be a good call, > too. I would find it very useful locally when running the tests too. A very simple approach would be to invoke prove with absolute paths to the tests. But that's not particularly pretty. But unless we change the directory that prove is run in away from the directory that contains t/ (there's a thread about that, but more to do), I don't think we can do better on an individual test basis? We could just make prove_[install]check echo the $(subdir) it's about to run tests for? Certainly looks better to me: make -j48 -Otarget -s -C src/bin/ check NO_TEMP_INSTALL=1 ... === tap tests in src/bin/pg_resetwal === t/001_basic.pl ...... ok t/002_corrupted.pl .. ok All tests successful. Files=2, Tests=18, 3 wallclock secs ( 0.01 usr 0.01 sys + 2.39 cusr 0.31 csys = 2.72 CPU) Result: PASS === tap tests in src/bin/pg_checksums === t/001_basic.pl .... ok t/002_actions.pl .. ok All tests successful. Files=2, Tests=74, 4 wallclock secs ( 0.02 usr 0.01 sys + 1.57 cusr 0.42 csys = 2.02 CPU) Result: PASS === tap tests in src/bin/psql === t/001_basic.pl ........... ok t/010_tab_completion.pl .. ok t/020_cancel.pl .......... ok All tests successful. Files=3, Tests=125, 6 wallclock secs ( 0.03 usr 0.00 sys + 3.65 cusr 0.56 csys = 4.24 CPU) Result: PASS ... Greetings, Andres Freund