Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYDO2-0000Tu-Th for pgsql-hackers@arkaria.postgresql.org; Sat, 26 Mar 2022 20:51:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nYDO1-0007aU-3c for pgsql-hackers@arkaria.postgresql.org; Sat, 26 Mar 2022 20:51:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYDNy-0007WW-Rk for pgsql-hackers@lists.postgresql.org; Sat, 26 Mar 2022 20:51:48 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYDNr-000899-A1 for pgsql-hackers@lists.postgresql.org; Sat, 26 Mar 2022 20:51:45 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8F5195C00E8; Sat, 26 Mar 2022 16:51:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 26 Mar 2022 16:51:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=VHNIXRQIJfWOM/AcRPSp8IWqE3u8y5Rg6r+89S OIhuM=; b=DmoIYSMo2asN12fGcg/d+4V+VucSOcTSqcziM9hQPfnNa+LF/4TBna Q/mbeDSmtiuAXRr3UlyQ35pBFjxpN553Km+iJxAzH6nyjWeO9cFN9ZMvKHfAPpMo Qd9TzmR8qt62+IzziouBoc8jufQp7bgKWu2gUTUDGp/cuqJEYg5rLHDwMPogJAuV LPCJ9sdAwhVHRtJIa7AXX3mpNmi9bLfIlZbnsUDOb/NNN0AtHxTclNxbwJeG16GF atCXi3KxwemSs3V76G0IgP4ONb3Il4MgT2VEeZNQYG8nld2bDR0jkwcCvn2AYgAG hXVbknDJFKWXzRVtZbmOeeN/VztuQUiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=VHNIXRQIJfWOM/AcR PSp8IWqE3u8y5Rg6r+89SOIhuM=; b=V+zdzWY6z1cNF4+5xc4ITP9+5aU5NceOD k/1R708yPKXsl3/3rJWwug5aWpzbnzt5ulDLkwmfrTEhx8W5771CcyzV3lK+0Yyv 7UfbiWIydssq+81gsyKGxkkNF9jKdB0Na+dsT7sRC80ynD2PANJbq42aT+8GyA79 +/b1Hea++Rq6zyxAGYY64E+rjkZnonw1sK1ODG8Q7iNsMY1uKIi1jSiXrqeP4yYE ZSClNfeE2+odXJWM8IIgjVuDcO6bvwwDjJtwdHFVJdom2jsddXID9CjGvYqcbWJw KhMLQlJOagL/3Pc3ylXVP7mf8dZLMYdG1alVd6vUORPdHex3TMPIA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehfedgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesmhdtreertddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepkeeijeehjeffgfduteetteevieelgfffkeelfedujeevkeekleevheev tedtgfelnecuffhomhgrihhnpehpohhsthhgrhgvshhqlhdrohhrghdpphhgshhqlhdrsg huihhlugenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pegrnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 26 Mar 2022 16:51:36 -0400 (EDT) Date: Sat, 26 Mar 2022 13:51:35 -0700 From: Andres Freund To: Tom Lane Cc: Robert Haas , Andrew Dunstan , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. Message-ID: <20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de> References: <20220315190428.2xf6klawmaq4nuyy@alap3.anarazel.de> <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net> <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> <144620.1648326272@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="da4jsg7mzy7mp3bs" Content-Disposition: inline In-Reply-To: <144620.1648326272@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --da4jsg7mzy7mp3bs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On 2022-03-26 16:24:32 -0400, Tom Lane wrote: > Robert Haas writes: > > On Sat, Mar 26, 2022 at 3:35 PM Andres Freund wrote: > >> === tap tests in src/bin/pg_resetwal === > >> t/001_basic.pl ...... ok > >> t/002_corrupted.pl .. ok > >> All tests successful. > > > Yeah, this certainly seems like an improvement to me. Do we want to do the same of regress and isolation tests? They're mostly a bit easier to place, but it's still a memory retention game. Using the above format for all looks a tad weird, due to pg_regress' output having kinda similar markers. ... ====================== All 22 tests passed. ====================== === regress tests in contrib/ltree_plpython" === ============== creating temporary instance ============== ============== initializing database system ============== ============== starting postmaster ============== running on port 51696 with PID 3905518 ============== creating database "contrib_regression" ============== CREATE DATABASE ALTER DATABASE ============== installing ltree ============== CREATE EXTENSION ============== running regression test queries ============== test ltree_plpython ... ok 51 ms ============== shutting down postmaster ============== ============== removing temporary instance ============== ... Could just use a different character. +++ doesn't look bad: +++ tap tests in contrib/test_decoding +++ t/001_repl_stats.pl .. ok All tests successful. Files=1, Tests=2, 3 wallclock secs ( 0.02 usr 0.00 sys + 1.74 cusr 0.28 csys = 2.04 CPU) Result: PASS Would we want to do this in all branches? I'd vote for yes, but ... Prototype patch attached. I looked through the uses of pg_(isolation_)?regress_(install)?check' and didn't find any that'd have a problem with turning the invocation into a multi-command one. > +1, but will it help for CI Yes, it should make it considerably better (for everything but windows, but that outputs separators already). > or buildfarm cases? Probably not much, because that largely runs tests serially with "stage" names corresponding to the test. And when it runs multiple tests in a row it adds something similar to the above, e.g.: =========== Module pg_stat_statements check ============= https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=peripatus&dt=2022-03-26%2000%3A20%3A30&stg=misc-check But I think it'll still be a tad better when it runs a single test: https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=snapper&dt=2022-03-26%2018%3A46%3A28&stg=subscription-check Might make it more realistic to make -s, at least to run tests? The reams of output like: gmake -C ../../../../src/test/regress pg_regress gmake[1]: Entering directory '/home/pgbuildfarm/buildroot/HEAD/pgsql.build/src/test/regress' gmake -C ../../../src/port all gmake[2]: Entering directory '/home/pgbuildfarm/buildroot/HEAD/pgsql.build/src/port' gmake[2]: Nothing to be done for 'all'. gmake[2]: Leaving directory '/home/pgbuildfarm/buildroot/HEAD/pgsql.build/src/port' gmake -C ../../../src/common all gmake[2]: Entering directory '/home/pgbuildfarm/buildroot/HEAD/pgsql.build/src/common' gmake[2]: Nothing to be done for 'all'. are quite clutter-y. Greetings, Andres Freund --da4jsg7mzy7mp3bs Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="make-test-subdir.patch" diff --git i/src/Makefile.global.in w/src/Makefile.global.in index 0726b2020ff..4014e437fc6 100644 --- i/src/Makefile.global.in +++ w/src/Makefile.global.in @@ -448,6 +448,7 @@ ifeq ($(enable_tap_tests),yes) ifndef PGXS define prove_installcheck +echo "+++ tap tests in $(subdir) +++" && \ rm -rf '$(CURDIR)'/tmp_check && \ $(MKDIR_P) '$(CURDIR)'/tmp_check && \ cd $(srcdir) && \ @@ -458,6 +459,7 @@ cd $(srcdir) && \ endef else # PGXS case define prove_installcheck +echo "+++ tap tests in $(subdir) +++" && \ rm -rf '$(CURDIR)'/tmp_check && \ $(MKDIR_P) '$(CURDIR)'/tmp_check && \ cd $(srcdir) && \ @@ -469,6 +471,7 @@ endef endif # PGXS define prove_check +echo "+++ tap tests in $(subdir) +++" && \ rm -rf '$(CURDIR)'/tmp_check && \ $(MKDIR_P) '$(CURDIR)'/tmp_check && \ cd $(srcdir) && \ @@ -663,6 +666,7 @@ pg_regress_locale_flags = $(if $(ENCODING),--encoding=$(ENCODING)) $(NOLOCALE) pg_regress_clean_files = results/ regression.diffs regression.out tmp_check/ tmp_check_iso/ log/ output_iso/ pg_regress_check = \ + echo "+++ regress tests in $(subdir) +++" && \ $(with_temp_install) \ $(top_builddir)/src/test/regress/pg_regress \ --temp-instance=./tmp_check \ @@ -671,12 +675,14 @@ pg_regress_check = \ $(TEMP_CONF) \ $(pg_regress_locale_flags) $(EXTRA_REGRESS_OPTS) pg_regress_installcheck = \ + echo "+++ regress tests in $(subdir) +++" && \ $(top_builddir)/src/test/regress/pg_regress \ --inputdir=$(srcdir) \ --bindir='$(bindir)' \ $(pg_regress_locale_flags) $(EXTRA_REGRESS_OPTS) pg_isolation_regress_check = \ + echo "+++ isolation tests in $(subdir) +++" && \ $(with_temp_install) \ $(top_builddir)/src/test/isolation/pg_isolation_regress \ --temp-instance=./tmp_check_iso \ @@ -685,6 +691,7 @@ pg_isolation_regress_check = \ $(TEMP_CONF) \ $(pg_regress_locale_flags) $(EXTRA_REGRESS_OPTS) pg_isolation_regress_installcheck = \ + echo "+++ isolation tests in $(subdir) +++" && \ $(top_builddir)/src/test/isolation/pg_isolation_regress \ --inputdir=$(srcdir) --outputdir=output_iso \ --bindir='$(bindir)' \ --da4jsg7mzy7mp3bs--