Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZb6P-0001vl-7I for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 16:23:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZb6N-0005LF-Pm for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 16:23:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZb6N-0005L2-Gg for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 16:23:19 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZb6K-0002gS-AO for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 16:23:19 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 06A6E320100E; Wed, 30 Mar 2022 12:23:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 30 Mar 2022 12:23:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=ZvNkR5+63TXEC9n/oGH+Zdl1rOxNrCBK0+5rxx IDVSE=; b=LB8w1tE5x2zNmVSr5Fonldh/CriR1hKBwG+LYlUAxyxWfTQZQZsorC yzCxjuebq//2LBj7Y1Y/KIW4GrQdAFU/bD3M++K5ZTIcQzemomyYNls77tGAE9o/ qWz/tsDy9oREPwWsgAAvhC7gTgzXbmJ0Q5imc1qy4N2G8kd1El05gg9TmiQFemnx nRY5sPFIOi1EQIQ00GUlVjCPID3jqt3j5g5mRfgJjZjU13qnVMGaYfdhlDSGM6Je eEiINlLixc6Xy+PiA4k0MY045nFJCGg5GoJNUNTldYYvixm9J53EZajBvbD1K1EF uaVjGkV8qCMe1EfxVN7+f1BrQJdE9Mtw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ZvNkR5+63TXEC9n/o GH+Zdl1rOxNrCBK0+5rxxIDVSE=; b=fa2dP72LoPfkEYmko+ePzPeyghkW7R7YC /V7BIZAoi29SHy80lTMwZkmysMpDLv5+HLBHw47iCzpdV3rb+eZtPK22i8QwrKH6 /C7MCalIGQ6g4RyLQmnMXhudN8QymVKe3o/yNCXb6NkR3vKN1k3U9jmseYpyBoRQ ggBl7pmsxIodgt3LQxr3Me7KkLeBhDiVONcirXFOzXLkaiqk4MBDsQ+0j1dIrg/a eJ5DTGHzVPEBk03IDEq1PjHIZu3CoX+Vi0lpeesYwE+NFGF8FJ8DawID6G6rz5pj k/jdhKkHtCOVuT1p4ySsVy6SsLrBIpKRs+/sjNyhEGF3iNuKFUBzA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeivddguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepvefhjeevhedvvdfgtdeufeeuhffhteekgfeftdekhfeiuedufeevudff udfgvdegnecuffhomhgrihhnpegtihhrrhhushdqtghirdgtohhmnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghnughrvghssegrnhgrrhgr iigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Mar 2022 12:23:12 -0400 (EDT) Date: Wed, 30 Mar 2022 09:23:11 -0700 From: Andres Freund To: Tom Lane Cc: Robert Haas , Andrew Dunstan , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. Message-ID: <20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de> References: <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net> <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> <144620.1648326272@sss.pgh.pa.us> <20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-03-26 13:51:35 -0700, Andres Freund wrote: > Prototype patch attached. Because I forgot about cfbot when attaching the patch, cfbot actually ran with it under this thread's cf entry. It does look like an improvement to me: https://cirrus-ci.com/task/6397292629458944?logs=test_world#L900 We certainly can do better, but it's sufficiently better than what we have right now. So I'd like to commit it? > Would we want to do this in all branches? I'd vote for yes, but ... Unless somebody speaks in favor of doing this across branches, I'd just go for HEAD. Greetings, Andres Freund