Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZbbx-00045Z-LY for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 16:55:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZbay-000561-Ch for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 16:54:56 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZbay-00055r-2A for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 16:54:56 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZbav-0001h8-QO for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 16:54:55 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 5CDB83202010; Wed, 30 Mar 2022 12:54:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 30 Mar 2022 12:54:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=kAKbQZhDjlNa9DeOnJotoFLwKYGHBHGy0CJLC9 5U0t0=; b=ueKLlOPdAIzK2wAYQmk0cVCZltQNxh479T/MJP4Pzs4y3nVea57Efy 2SEa/myaWIaWQN4hmdCohyNeVSbTzHnLXAsBadhx98gmLvpkzVKsrNUyVBBWhNM0 oyxd3MJMtA+UEyKJpqM06+CG4nGoQuPuDtUGbrsVm08aqrtngXMb0hlLLcQsd4HW 0t+73p1keoB8qjXUGhn8mAiFE3NvhfdDD5pfuBWr0cG7gD23WVk9eDPVnDwcNYtv NFBg5AIBCe7OZPliZmliqVYp3cpJAN2SeCDy2MzxkKTGhwi+DeDJJTxgHSuPcNcE QgAumocyuVbLf3VzHBuaSXgamcXH+wVg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=kAKbQZhDjlNa9DeOn JotoFLwKYGHBHGy0CJLC95U0t0=; b=c2LLTtR9oPSea8x/Dw8xaNrp5JS881RP2 lAqCWY9vjrk2pcZvkwBax2JPQXL2zpFXQvomVqCJw0Dn8aqddkEGVEBR2jXC7nnC plu4krmSwjQyBJuTn3UVjronKX0dWPF4c7UPM1x8Uy0nmklwyxpWIcCcpoTYzPui DyGnIw6yHTMv3EdNwtaYVvzu05wf8y7s7LDh9WsL5PKEtlPlw3nAqYnmMim2Un0r Lw5HA4PIrqEzGKIYcZo3T5XJHrYPbR6DL2qNqM8g5sRqcMl5DJ2LVM6TJJcSvUXE FAuhmTLu4LwFqbqdno7lLVanOuYUpGmUAWkyRAwXqbAAn4LqIfgbA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeivddguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepudekhfekleeugeevteehleffffejgeelueduleeffeeutdelffeujeff hfeuffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Mar 2022 12:54:51 -0400 (EDT) Date: Wed, 30 Mar 2022 09:54:50 -0700 From: Andres Freund To: Robert Haas Cc: Andrew Dunstan , Thomas Munro , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. Message-ID: <20220330165450.3lruwky7eveddsvq@alap3.anarazel.de> References: <20220329222504.aylyimyub6igsvpy@alap3.anarazel.de> <684ed71e-0876-60c0-8e44-066ba702f0a6@dunslane.net> <20220330163024.fsbpbxwxh5oo2ktx@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-03-30 12:42:50 -0400, Robert Haas wrote: > On Wed, Mar 30, 2022 at 12:30 PM Andres Freund wrote: > > # Reconfigure to restrict access and require a detail. > > $shell_command = > > $PostgreSQL::Test::Utils::windows_os > > ? qq{$gzip --fast > "$escaped_backup_path\\\\%d.%f.gz"} > > : qq{$gzip --fast > "$escaped_backup_path/%d.%f.gz"}; > > > > I don't think the branch is needed anymore, forward slashes should work for > > output redirection. > > We have similar things in src/test/perl/PostgreSQL/Test/Cluster.pm. There are some commandline utilities (including copy) where backward slashes in arguments are necessary, to separate options from paths :/. Those are the extent of backslash use in Cluster.pm that I could see quickly. > I'm not sure it's the place of this patch to introduce a mix of styles. Fair enough. I found it a bit grating to read in the test, that's why I mentioned it... Greetings, Andres Freund