Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZdkZ-000484-Dn for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 19:12:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZdkX-0003hC-HB for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 19:12:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZdkW-0003h2-LR for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 19:12:57 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZdkU-0002tA-0W for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 19:12:55 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D02A85C004D; Wed, 30 Mar 2022 15:12:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 30 Mar 2022 15:12:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=fu8sKDAfcAYscb3Pksk+RGWUpHOjTrvgn0LB6r Oj/y4=; b=Gr430z3cdrx/Svny3P4kFIoCxM79PvqHMdoAdWSlxDMNgRJPnnTinS WQHXhbrcU5ZJbs30KeVrHrmM6i1xbLiyioNXRVN+8I3phOxvZDJrLpPF9w1jxjhk f9HByT5R+YArQw+JOlYbEd7Pn826yVVfBon/3uaqxwgo+oRZ7gkEpeUHlHfKFn0A BMz7tLtR7IMMxnPLBY0dX+CFPcpD3dFJvWiQsyyxgjvysfRjsqLhzXwlVraZtVMp a4wjPx4HN3iw5U07L/rm9CCJ1bWHF7A9nEIgi+/9mHDwdxXRXUK3FK770sCs2POI VGE3JnpOhTwN4t+4OqK/ATfYccuV8OIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=fu8sKDAfcAYscb3Pk sk+RGWUpHOjTrvgn0LB6rOj/y4=; b=F+nsxx6wBuootw/SjW63NhZcMxfq6/ntP wuD8zli1y6wdUo9ve+GfW/LGCTT1lms04OGVEHlo1pBv5hwEksffWHi3Fcm7wxSS 4ASB5GuQM6kWzBcNVHtMAWatXqr/+Lsn7LdbMf9iVO9vQrOWxGqVrPh59fDbXjU4 OtKFRqsTuTicB49G5Q12wI2YFA/eoj1XRqIwNd6avPQR7O2uuD1SfvXpPpz2e+eh N5IoKEeMnSwLgL3lOsuEt4UDmngw5XhRPkjD1wSlnwImrgMgvDml6kyMpNOTy1pW /aD+jAZa/XctwSIEQZC5BMXoDBBaWuDAn4DDMMhuq8nMs83bGSb1g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeivddgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepudekhfekleeugeevteehleffffejgeelueduleeffeeutdelffeujeff hfeuffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Mar 2022 15:12:52 -0400 (EDT) Date: Wed, 30 Mar 2022 12:12:51 -0700 From: Andres Freund To: Robert Haas Cc: Tom Lane , Andrew Dunstan , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. Message-ID: <20220330191251.sgxjox64k3eteylb@alap3.anarazel.de> References: <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> <144620.1648326272@sss.pgh.pa.us> <20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de> <20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de> <228044.1648658074@sss.pgh.pa.us> <20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de> <230838.1648659506@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-03-30 13:16:47 -0400, Robert Haas wrote: > On Wed, Mar 30, 2022 at 1:11 PM Andres Freund wrote: > > On March 30, 2022 9:58:26 AM PDT, Tom Lane wrote: > > >Andres Freund writes: > > >> Random aside: Am I the only one bothered by a bunch of places in > > >> Makefile.global.in quoting like > > >> $(MAKE) -C '$(top_builddir)' DESTDIR='$(abs_top_builddir)'/tmp_install install >'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1 > > >> and > > >> rm -rf '$(CURDIR)'/tmp_check && > > >> etc > > > > > >Don't we need that to handle, say, build paths with spaces in them? > > > > My concern is about the quote in the middle of the path, not about quoting at all... I.e. the ' should be after /tmp_install, not before. > > Makes no difference. We know that the string /tmp_install contains no > shell metacharacters, so why does it need to be in quotes? I would've > probably written it the way it is here, rather than what you are > proposing. It looks ugly, and it can't be copy-pasted as easily. Seems I'm alone on this, so I'll leave it be... Greetings, Andres Freund