Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZh0N-0000Hm-EY for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 22:41:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZh0L-0000wU-70 for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 22:41:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZh0K-0000wL-SE for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 22:41:28 +0000 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nZh0I-0005z4-83 for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 22:41:28 +0000 Received: by mail-io1-xd2d.google.com with SMTP id k25so26549999iok.8 for ; Wed, 30 Mar 2022 15:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gOjGHEl95y9hVwgRx1iiVwhicFpBjgTUotQr7BYhGBM=; b=aTO7lykPhYdfI6gEl2lPjAhmb00DJdxxIquFQzroYqZRkf/6YiACepMWlYVEVipJz1 RaOeOn2sf0aWsWMmSf3KPpSrKetC6zKXm6beth7yKCLDO/LFm4eLwU3goF49Rye4RbQq ZqSFanacLN3DCzi//SD6CYhWJF02dqGrGGUSjl7GGF8S8/9ur62o9goW955/FcTrJBo7 lhkz8qyJs0TDhHOnr/z+p0TVRsQvbsXzqORU14/lw5LLK+m1FGujHEkomsis+Yes5AP0 bu8CxAXiNkT4neBWqiMnhyEzJ2XlQTG9wtGaWOjZPJ/VbeAi216JNx3yX+fSrMiToif0 CDyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gOjGHEl95y9hVwgRx1iiVwhicFpBjgTUotQr7BYhGBM=; b=bA/3lusHiy5egCdNIqciTYnUi1VRXhFb2gLMGYjLhPCWPyUpwj7EBosJjCeK7opGF1 qe2OX5zX1GqWg/dtmQJyP0DjHzoj6LTD73aXWhCAOdGwpCcoebbTQiPbt6I0Xhy4ycMv rGPV8cPTLI1AuEB/+oDlSpb8vn8CcxZpGlInUJlDhgY8Hpu/S4tLml/OeNs7ajyJfovo O5LmE40o/c4qIDIV0yUZWv/FV+cnU4q1tk/HN6nPfjhdGNGdMfzX+FLDThKJ8Xzr6R2h /PibeY2N6IOQ1gXUxuKJRATFBuniWwtZ/D1oZMtbCWWbIfG4Gbbfr14VP+61dp/9DIKq RyAQ== X-Gm-Message-State: AOAM530Q3+n5js+8jXNckq3JULXpckiBwbRnUtM1QlxXvfZFvMxpTDBJ 6jxeZD1a33n9wrVK0rwxf2xvXWtyWP0= X-Google-Smtp-Source: ABdhPJyib55U6h/2T/YTLajXCdkhVTKLWo2vE1akXoan5D5fdUUPvmUt4UJcjv5TemkbXB+D5vuY7w== X-Received: by 2002:a05:6638:1c1a:b0:323:8ec2:e187 with SMTP id ca26-20020a0566381c1a00b003238ec2e187mr1332500jab.163.1648680084067; Wed, 30 Mar 2022 15:41:24 -0700 (PDT) Received: from nathanxps13 ([2600:1700:48f8:340f:aa19:1a7d:e646:4900]) by smtp.gmail.com with ESMTPSA id e4-20020a056e0204a400b002c9aeff7530sm6024610ils.26.2022.03.30.15.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 15:40:38 -0700 (PDT) Date: Wed, 30 Mar 2022 15:39:43 -0700 From: Nathan Bossart To: Robert Haas Cc: Tom Lane , Andres Freund , Andrew Dunstan , Thomas Munro , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. Message-ID: <20220330223531.GA134543@nathanxps13> References: <20220329222504.aylyimyub6igsvpy@alap3.anarazel.de> <684ed71e-0876-60c0-8e44-066ba702f0a6@dunslane.net> <20220330163024.fsbpbxwxh5oo2ktx@alap3.anarazel.de> <20220330165450.3lruwky7eveddsvq@alap3.anarazel.de> <285252.1648671723@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3V7upXqbjpZ4EhLz" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --3V7upXqbjpZ4EhLz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I think we should give this module a .gitignore file. Patch attached. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com --3V7upXqbjpZ4EhLz Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-add-.gitignore-for-basebackup_to_shell.patch"