Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZkNI-0005D2-Lv for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Mar 2022 02:17:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZkNH-000123-Bx for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Mar 2022 02:17:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZkNG-0000yu-U0 for pgsql-hackers@lists.postgresql.org; Thu, 31 Mar 2022 02:17:22 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZkNE-0006FW-HT for pgsql-hackers@lists.postgresql.org; Thu, 31 Mar 2022 02:17:21 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id AF3495C0139; Wed, 30 Mar 2022 22:17:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 30 Mar 2022 22:17:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=zGrQSTPWM2ofuvNyAe6psqjBRiwQ8MAHg9aGVB cJfWw=; b=C9ysZJa2FrfDcOw27Ps+HdRKIOBoq72Oa0dLsIJnww5rlTNDjv8/rS K0oFpL3yGZpxqIK+DivulhLzPiaXN3FBWmaO+zzlpGm9U1LGQ8CLhxkOZbOn1sbk 8Pna9jQPR9kwrDWBLp/Pm4g9vkSynZZNpDgKo2TPUl+dVQ7VIHgEYEqwTWxolJR3 1hneOFq5f1MqFu46Audkv9W8JqZ596/PkyUIUe43EUcRdG/34pozxDEioQN35ryU IjNzRUrrrO8aQ4C+p1aQJArmuPXn9msYH/8Rt7kwx76OXp95/n4ResWuVsH4CwGd XM3AApOTadE7t4YZQBpXPYqWiWUzs5DA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=zGrQSTPWM2ofuvNyA e6psqjBRiwQ8MAHg9aGVBcJfWw=; b=ArQ7yvAwFUeFikCHrfhTgXZQ8udsxwHRt Nruhg0zWSpR3V0/xZWIlmRLd0LzEPc8iPc1rSfCF2eR5V9ahfM0pzo1arOuLsdYu vyD8eO+GwhjIHrfarq7LkKtyNisWqKE5nsl0BKpnyO66ZNhMy5PMxAHk4yrJnB17 d79DU2YLqLect83POoO/70uZypFrDHPwe+GCskKTJIdsCVjEFfGv723QxPVP/dFR G6dURfVYEMUpsX4t894vpUXFUoSBv0nvaDL0SQMuYmgeOk1h/1qqPuLJLnX2gzfo PZjlpbZlXCrjvmpW0K/kEZ8xHG+gpYV7C/5qtvCMS/cUIe5HbaAkg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeifedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpedukefhkeelueegveetheelffffjeegleeuudelfeefuedtleffueejfffh ueffudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Mar 2022 22:17:18 -0400 (EDT) Date: Wed, 30 Mar 2022 19:17:17 -0700 From: Andres Freund To: Tom Lane Cc: Robert Haas , Nathan Bossart , Andrew Dunstan , Thomas Munro , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. Message-ID: <20220331021717.xusjlknpbs7szyv6@alap3.anarazel.de> References: <20220330163024.fsbpbxwxh5oo2ktx@alap3.anarazel.de> <20220330165450.3lruwky7eveddsvq@alap3.anarazel.de> <285252.1648671723@sss.pgh.pa.us> <20220330223531.GA134543@nathanxps13> <472639.1648684865@sss.pgh.pa.us> <485495.1648692468@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <485495.1648692468@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-03-30 22:07:48 -0400, Tom Lane wrote: > So ... none of the Windows buildfarm members actually like this > test script. They're all showing failures along the lines of > > not ok 2 - fails if basebackup_to_shell.command is not set: matches > > # Failed test 'fails if basebackup_to_shell.command is not set: matches' > # at t/001_basic.pl line 38. > # 'pg_basebackup: error: connection to server at "127.0.0.1", port 55358 failed: FATAL: SSPI authentication failed for user "backupuser" > # ' > # doesn't match '(?^:shell command for backup is not configured)' > > Does the CI setup not account for this issue? On windows CI sets # Avoids port conflicts between concurrent tap test runs PG_TEST_USE_UNIX_SOCKETS: 1 because I've otherwise seen a lot of spurious tap test failures - Cluster.pm get_free_port() is racy, as it admits: XXX A port available now may become unavailable by the time we start the desired service. The only alternative is to not use parallelism when running tap tests, but that makes test runs even slower - and windows is already the bottleneck for cfbot. I assume SSPI doesn't work over unix sockets? Oh. Maybe it's not even that - we only enable it when not using unix sockets: # Internal method to set up trusted pg_hba.conf for replication. Not # documented because you shouldn't use it, it's called automatically if needed. sub set_replication_conf { my ($self) = @_; my $pgdata = $self->data_dir; $self->host eq $test_pghost or croak "set_replication_conf only works with the default host"; open my $hba, '>>', "$pgdata/pg_hba.conf"; print $hba "\n# Allow replication (set up by PostgreSQL::Test::Cluster.pm)\n"; if ($PostgreSQL::Test::Utils::windows_os && !$PostgreSQL::Test::Utils::use_unix_sockets) { print $hba "host replication all $test_localhost/32 sspi include_realm=1 map=regress\n"; } close $hba; return; } Greetings, Andres Freund