Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZnIy-0007YM-FZ for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Mar 2022 05:25:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZnIx-0003r1-5u for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Mar 2022 05:25:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZnIw-0003qr-Sj for pgsql-hackers@lists.postgresql.org; Thu, 31 Mar 2022 05:25:06 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZnIt-00015U-Us for pgsql-hackers@lists.postgresql.org; Thu, 31 Mar 2022 05:25:06 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3AF8A5C0185; Thu, 31 Mar 2022 01:25:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 31 Mar 2022 01:25:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=FfLwPs2IflMfTAk2IweUcgyoslliFnDQZelmjv Ya498=; b=Gk1eWJI52sdI3/lLFZgdoV4NdY1Xi0FBQ08/z/8WS9uFyPWBsR2JL2 3lecn+qnFdTYQSA1PMX/lnC0/XG6tdL41PK230kvKOjfT96FdwnwYPuKOf7fBP7f ZoEc6Xu7iIxbSWkKsDBgEuI/NjmMU5sSCmpqvcPVB4VxL+9PJTmLYSygvs279zdq WtvFloSddgahv1F11BHHbG3kJ5OLP7IXiADwhXXWAs8EWKXjpWFELh7xOtxBimWD 2FMdwYsA/SfObcHiSi546RXrGo39BFO1sct5YpOkuGXTm8AkSALMCTiF7fWqHFAH emtvIfrU8MOUeDDke5QeH0VXxRoOpajA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=FfLwPs2IflMfTAk2I weUcgyoslliFnDQZelmjvYa498=; b=Ku6GN6IcJeNXjgMl1NELhkvpReok0ilIB kRGye7HXsSHiHEymQDRUWE20M+99bT+Vs6JSxSd1PXe+Boywv0ip+U86rOIFjMqf OITvstmHwlmPjD/e6jMz2jwXNlbBFlMAVSupLm1tN+PASbHls6aX9MEEh+gUFLUE JfUERrzBfOYfdlfcBFPD0OvZe9MuyBJt/TvDh8VDxtmfqlGIIBdNkBwD+eguQnEk RKByg00noKync7xUo1sDRyvcRD69IAf2gsMx9v/JhGzrUHn1qT5CiACb1hbQPDo5 wL7HMXrA0WoLVmrHhxzZdSLuA0sg7/vHDt2xigLdQWetq6IJUj4bw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeifedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpedukefhkeelueegveetheelffffjeegleeuudelfeefuedtleffueejfffh ueffudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 31 Mar 2022 01:25:01 -0400 (EDT) Date: Wed, 30 Mar 2022 22:25:00 -0700 From: Andres Freund To: Tom Lane Cc: Robert Haas , Nathan Bossart , Andrew Dunstan , Thomas Munro , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. Message-ID: <20220331052500.eidoln5dcrhqza7b@alap3.anarazel.de> References: <20220330165450.3lruwky7eveddsvq@alap3.anarazel.de> <285252.1648671723@sss.pgh.pa.us> <20220330223531.GA134543@nathanxps13> <472639.1648684865@sss.pgh.pa.us> <485495.1648692468@sss.pgh.pa.us> <20220331021717.xusjlknpbs7szyv6@alap3.anarazel.de> <497188.1648699680@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <497188.1648699680@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-03-31 00:08:00 -0400, Tom Lane wrote: > Andres Freund writes: > > I assume SSPI doesn't work over unix sockets? Oh. Maybe it's not even that - > > we only enable it when not using unix sockets: > > Duh. But can it work over unix sockets? I wonder if we should go the other way and use unix sockets by default in the tests. Even if CI windows could be made to use SSPI, it'd still be further away from the environment most of us write tests in. Afaics the only reason we use SSPI is to secure the tests, because they run over tcp by default. But since we have unix socket support for windows now, that shouldn't really be needed anymore. The only animal that might not be new enough for it is hamerkop. I don't really understand when windows features end up in which release. Looking at 8f3ec75de40 it seems we just assume unix sockets are available, we don't have a version / feature test (win32.h just defines HAVE_STRUCT_SOCKADDR_UN). Greetings, Andres Freund