Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZzmI-0005ow-C2 for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Mar 2022 18:44:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZzmG-0003xL-8k for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Mar 2022 18:44:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZzmE-0003xC-Bt for pgsql-hackers@lists.postgresql.org; Thu, 31 Mar 2022 18:44:11 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZzmA-0006DN-Uk for pgsql-hackers@lists.postgresql.org; Thu, 31 Mar 2022 18:44:08 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 224D2320077A; Thu, 31 Mar 2022 14:44:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 31 Mar 2022 14:44:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=1bjcd8k4pNlXJnH7nHgFu0JOK7yXnkHAjyWT18 KRyCQ=; b=X5aAWHK3dieNi/gk5NUncb++VsGnvD9g8ky0i8AUrlu8krFc5aeMvm ihdLLzVok6jhPy7JZKRE+cIEbJfuK0F3EmDVCJMm2fQ1WCKMj1NasNolY40/kWk4 MtoSMPHxj94edqikNVh/yk3ZHR+jX4D2VCfAaxz04TFNNbn8H8u6fwGjbKKU1Z4x 3FO8D6tlluAqg1msV7jBJtGeBNCD+SGGFzaFiqCxAj1xpeCys+D5wraneY693obF 7ucGj0EJNx5drwnUXClB8hggibSZgxIFBPZhSR+wwsDXJ3h4J19A45dIbU4t1UB7 JD8Ae9mQVmvBFMvgnYRKmBOSszpX0+YA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=1bjcd8k4pNlXJnH7n HgFu0JOK7yXnkHAjyWT18KRyCQ=; b=f2rAFWA8vq00+/giEJUzGsvY1sh+NrTEq Oz48CXv7RPIgFJCTy+zgJ7M5H3V3dmtSww1+kJtEE8dKD6bAs5Sl6Hp6kZVshsc+ 2VxH6nSWRnaGscOgobNusSjAUx2MQbTcDvxluhcKIyIGXuXiWBqGRb257PWj62mK GyO1oRAZGFUk4vVBZJZmpgfsUTJ62J0+4eFAKHpTGaUVd6DESTLl3jv6Q93zw8+S eekBanGon1Z4BZxt+MTexglGPlL8pfFc3L0RI04siir6ub4pE8TejWIZwx1RtKuG dL6T78dxOKLjFmK8DWlCdnxY3APgFcQVFF3Sobg+fwtxdE8XCpP5w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeigedguddvlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepudekhfekleeugeevteehleffffejgeelueduleeffeeutdelffeujeff hfeuffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 31 Mar 2022 14:44:03 -0400 (EDT) Date: Thu, 31 Mar 2022 11:44:02 -0700 From: Andres Freund To: Tom Lane Cc: Robert Haas , Andrew Dunstan , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. Message-ID: <20220331184402.an4xql765rydiywm@alap3.anarazel.de> References: <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net> <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> <144620.1648326272@sss.pgh.pa.us> <20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de> <20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de> <228044.1648658074@sss.pgh.pa.us> <20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de> <230838.1648659506@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <230838.1648659506@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-03-30 12:58:26 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2022-03-30 12:34:34 -0400, Tom Lane wrote: > >> One refinement that comes to mind as I look at the patch is to distinguish > >> between "check" and "installcheck". Not sure that's worthwhile, but not > >> sure it isn't, either. > > > As it's just about "free" to do so, I see no reason not to go for showing that > > difference. How about: > > > echo "+++ (tap|regress|isolation) [install-]check in $(subdir) +++" && \ > > WFM. Pushed like that. Greetings, Andres Freund