Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbzDC-0005WT-Cj for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Apr 2022 06:32:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nbzDA-0001OO-KX for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Apr 2022 06:32:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbzDA-0001OE-9P for pgsql-hackers@lists.postgresql.org; Wed, 06 Apr 2022 06:32:12 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nbzD7-0000AL-0J for pgsql-hackers@postgresql.org; Wed, 06 Apr 2022 06:32:11 +0000 Received: by mail-pj1-x1035.google.com with SMTP id ch16-20020a17090af41000b001ca867ef52bso3666578pjb.0 for ; Tue, 05 Apr 2022 23:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:message-id:to:cc:subject:from:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=FpaanUZNR4odf35fbM/+HZjLI21cTfXD0mtRW/AXN4s=; b=W47q5C+3CjOPu2+ydxZkvO1TgeMytbDPLjUD0NMRNR2tIcLAGwaKlxWXJbAqrgWGfB EXN19KPmdK/PnC26ZdtfrxhCBawq2rIH7SQgAmr8/y9xE49TEEC8emvMT3rbQiSppHSg IbM6C0zuT2HsvjjwGal4GARr5l9AtQbihTtPPEVL+nQkjPWGZO0048pyX+MmVbQGKPpf tlcwLTeHAlxcSZolaCRy09sDHRDTmWa+HgfSXWMBK2yx3yfvZjYCH/ztwCzaI3co7spg sea8Lb5L9T/nmRrcsepLd8cVZdBreYeMZRcKpYF+277JZ9MwA88m/Xy1sjE3hTLu7O7g Xk1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:to:cc:subject:from:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=FpaanUZNR4odf35fbM/+HZjLI21cTfXD0mtRW/AXN4s=; b=t+OeQU46DjkeWnSkuFjOhRXoUD40y74iOvQ90HGqGY7rFQhRR8wD9SxgwdoK/Ia95y qfPbqrrNT2fPfH1mIcugF4rFgS85XR13rRUvQg7zRZzO09Opvkh0kszYBIQ22KYZPdy0 j/YHd6zEKlK/GU96+c1pjNS3iwh8OvJSjkVS24CbzG0bJDp2ksBLSNUK8ndIHgolemQk mO2mVi7jnTcy87o6Ip43m0bzVJh8baDp33R5D9/DxMuesfhaY3IMYNrAGiqL/4GVb1tK YVRqZPMjCkV0GiGlPsXqew17MFTs6PEjuco/QEQmzGxn5PBjAFr9l7O6a52uTemYDdxc wRcA== X-Gm-Message-State: AOAM531eq/vcCyHvvZsd3Cv1jCwx8rMBGdq8Upp7LRIaGOlfOJO+t4TU wPUUAuXow/zIwsK/2SkYmFI= X-Google-Smtp-Source: ABdhPJz8PGhZxGQbtI1WmZUvKlMVPEoTBzG7YTT+WyRmR4Vzh8mBiLJA6m+JhxWa9/TaFzNtMKNdpw== X-Received: by 2002:a17:903:1210:b0:14f:973e:188d with SMTP id l16-20020a170903121000b0014f973e188dmr7127832plh.61.1649226727955; Tue, 05 Apr 2022 23:32:07 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id q15-20020a056a00150f00b004fb28ea8d9fsm18785082pfu.171.2022.04.05.23.31.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 05 Apr 2022 23:32:02 -0700 (PDT) Date: Wed, 06 Apr 2022 15:31:53 +0900 (JST) Message-Id: <20220406.153153.746094489184530420.horikyota.ntt@gmail.com> To: robertmhaas@gmail.com Cc: markus.wanner@enterprisedb.com, pgsql-hackers@postgresql.org Subject: Re: API stability From: Kyotaro Horiguchi In-Reply-To: <20220406.143037.1305948883608926192.horikyota.ntt@gmail.com> References: <20220406.103630.334298501828781936.horikyota.ntt@gmail.com> <20220406.143037.1305948883608926192.horikyota.ntt@gmail.com> User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk At Wed, 06 Apr 2022 14:30:37 +0900 (JST), Kyotaro Horiguchi wrote in > So if we don't want to move any member in PGPROC, we do: > > 14: after statusFlags. > 13: after delayChkpt. > 12-10: after syncRepState (and before syncRepLinks). > > If we allow to shift some members, the new flag can be placed more > saner place. > > 14: after delayChkpt ((uint8)statusFlags moves forward by 1 byte) > 13: after delayChkpt (no member moves) > 12-10: after subxids ((bool)procArrayGroupMember moves forward by 1 byte) > > I continue working on the last direction above. Hmm. That is ABI break. I go with the first way. regards. -- Kyotaro Horiguchi NTT Open Source Software Center