Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbzY0-0006FO-1l for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Apr 2022 06:53:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nbzXy-00019l-Vd for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Apr 2022 06:53:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbzXy-00019c-L1 for pgsql-hackers@lists.postgresql.org; Wed, 06 Apr 2022 06:53:42 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nbzXw-0002ZS-GU for pgsql-hackers@postgresql.org; Wed, 06 Apr 2022 06:53:42 +0000 Received: by mail-pl1-x634.google.com with SMTP id f10so1168869plr.6 for ; Tue, 05 Apr 2022 23:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:message-id:to:cc:subject:from:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=B6yqyIJzLqIrPQN0N9LKiiIiDQgFphEdVyzpyOgnBzc=; b=Zd+DCBc3k6AC56HpqRQr4E3OrBN/CwjES3qcirV3y1Qaw/yLfzEZ2cQue0nnJ/Xvbn TqdOG4eptKmjuVQlR0B1Fu6hUQDw4pIH/KajEPWVwmpq5RxkGVwrHTWL6Znw06BYX5t9 VZmrJEZxgQBQ44rMmtNM2rK9yYe5Q7Rxf7DAiPFxuWbkcKoDCPyP1lS6valxTL9BBaIj 1tSNlBeUjVzKVReQlncoV62ZzHibYtU1FJOkqmnTX7xnvHy1jBU3fnkmgPhKS/6Ung2v 1U87VkkYAXyevj6IaRTce3iS7Mvyu7SfPAP4dnOJUSBtrbMfxzeomL+EJC/PcLsL1x/U n1aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:to:cc:subject:from:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=B6yqyIJzLqIrPQN0N9LKiiIiDQgFphEdVyzpyOgnBzc=; b=hS0sJn/ASfFagOG/hc1fN00TtvSQiOi8mP8MJogMdpxjg2A9o0DdNGGPDP+UNMcUM6 jI1NS5jvvsH246auvBhxNkasaxRusz2HiPfonZmVu7ScvbgvlmdLE3MfkJSWPqrv2cLj 9xt9eUGZy6PfmND6zzrf6WtnbQ3tXBdnRzP/3Fft41quBQrgh5YT1CnA/H3LDB5rNKE6 uoThIrc6PDjy2i1DChB1kP80nG8ZpWKQnIMumnTdlO8BAjy/xtvVbibhZHohrtRIprao WgQPH4mHYjAFiGVrH+EOFg9SJ+Rs5CVm6gt9K1g0j4RVMlERatwfPzUdWfnnmMNch0tj s7zw== X-Gm-Message-State: AOAM532GPiyd98Me/k2uLqSni0BxVw/zYq/u3uz5VHW16HoNtzcdpuW7 QeT8+2Qo7I6DS2vzQtAA/fI= X-Google-Smtp-Source: ABdhPJx0+wdE6Ht7UkFt/+Ij1f9DbTZvVbOAzrhlDhbJrGuoPZH7E6Op+suuoComJfspPWpMJoebfg== X-Received: by 2002:a17:90b:1652:b0:1c7:305f:3a32 with SMTP id il18-20020a17090b165200b001c7305f3a32mr8174716pjb.108.1649228017502; Tue, 05 Apr 2022 23:53:37 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id v22-20020a056a00149600b004fb34a7b500sm18284635pfu.203.2022.04.05.23.53.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 05 Apr 2022 23:53:36 -0700 (PDT) Date: Wed, 06 Apr 2022 15:53:32 +0900 (JST) Message-Id: <20220406.155332.1780268842430625734.horikyota.ntt@gmail.com> To: robertmhaas@gmail.com Cc: markus.wanner@enterprisedb.com, pgsql-hackers@postgresql.org Subject: Re: API stability From: Kyotaro Horiguchi In-Reply-To: <20220406.153153.746094489184530420.horikyota.ntt@gmail.com> References: <20220406.103630.334298501828781936.horikyota.ntt@gmail.com> <20220406.143037.1305948883608926192.horikyota.ntt@gmail.com> <20220406.153153.746094489184530420.horikyota.ntt@gmail.com> User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk At Wed, 06 Apr 2022 15:31:53 +0900 (JST), Kyotaro Horiguchi wrote in > At Wed, 06 Apr 2022 14:30:37 +0900 (JST), Kyotaro Horiguchi wrote in > > So if we don't want to move any member in PGPROC, we do: > > > > 14: after statusFlags. > > 13: after delayChkpt. > > 12-10: after syncRepState (and before syncRepLinks). > > > > If we allow to shift some members, the new flag can be placed more > > saner place. > > > > 14: after delayChkpt ((uint8)statusFlags moves forward by 1 byte) > > 13: after delayChkpt (no member moves) > > 12-10: after subxids ((bool)procArrayGroupMember moves forward by 1 byte) > > > > I continue working on the last direction above. > > Hmm. That is ABI break. I go with the first way. By the way, the patch for -14 changed the sigunature of two public functions. -GetVirtualXIDsDelayingChkpt(int *nvxids) +GetVirtualXIDsDelayingChkpt(int *nvxids, int type) -HaveVirtualXIDsDelayingChkpt(VirtualTransactionId *vxids, int nvxids) +HaveVirtualXIDsDelayingChkpt(VirtualTransactionId *vxids, int nvxids, int type) Do I need to restore the signature? regards. -- Kyotaro Horiguchi NTT Open Source Software Center