Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nc0MC-0000HW-7l for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Apr 2022 07:45:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nc0MA-0001Np-OO for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Apr 2022 07:45:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nc0MA-0001Ng-BF for pgsql-hackers@lists.postgresql.org; Wed, 06 Apr 2022 07:45:34 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nc0M3-00034S-54 for pgsql-hackers@postgresql.org; Wed, 06 Apr 2022 07:45:34 +0000 Received: by mail-pg1-x532.google.com with SMTP id t13so1530753pgn.8 for ; Wed, 06 Apr 2022 00:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:message-id:to:cc:subject:from:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=8mw814dJPHzKrUZ0Yn2IlfTQpN6LSIVq57opwa10EuA=; b=QXLaUxfnqQMNbg8eohgz8vkdkk5yd9IYxSH+eBE+mS6P8mjy6zFlspwnrWqbgtymOu ph75Q58c2bqnMTFISYHzr3ACrjmUUh6P+64Ty5rvDBR8RVzLWobxZ3wvmgSaHD0Snzmi KBOFeAHlHWfyq7b7Zt8+VHgZkN56Qu5ccfEopp5Bnw3LA2nkVJVwr7xHJmDXDg4YUZYt q3ry074LkncS85FVmAb33n2MgC8eurOLCadTBxX/HMPts6SH5HYSvE15ZpoSmqSuXGSy 03QRPoFx9CXfI2+BFjJuk7JP61X1sJIDJJ8t3IqTnezV/VqpSekvvrBJAS3IrlCte/Ky swKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:to:cc:subject:from:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=8mw814dJPHzKrUZ0Yn2IlfTQpN6LSIVq57opwa10EuA=; b=X5KE/FJ3hDOaAMKvci2/WzsQvz/IjelNA6z+vyRaCwsrMKXLEL4mV/6/t9LLSm7Gmh k8u8Cw/MwzLVGJY3NbeVrF4bqlQK7UoOV3vN115uvoAwyu90heIwgdrqJaGbkj1b8zWV ph4KEQ87hGns4yMr/0PVXrG12vNnA8gWqZhBZFAtDMwKMwqUUelcw534Nh/Fcizu+gKo +nSZUx/7pZyKxOOadO8yO+ZgWYa5lnQhQpnUpPGMO92KVi68e3NnpJFsLiq45OHkTBci +po+nc8GtlZBXk0cOg9EEe2ndBgg6qoa2LX6fZMfh83TWuFVbgNixnZXzaXfKHCh8Lb0 Mxeg== X-Gm-Message-State: AOAM531resyHHr1hTu76QlvbhWlshXsIQwyZnD1feP/qw2rKtZRCdKuN N4R8rwHYjLhPFGDCshAjzSo= X-Google-Smtp-Source: ABdhPJwfcqVdruqToeRYE8HlvTwDevF34919JXiQAtqOCBwZT//Z0XxA7gDCcViF6CYlhwBa67YU2Q== X-Received: by 2002:aa7:90d5:0:b0:4e1:307c:d94a with SMTP id k21-20020aa790d5000000b004e1307cd94amr7496819pfk.38.1649231124777; Wed, 06 Apr 2022 00:45:24 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id d5-20020a633605000000b0039815688655sm15630492pga.0.2022.04.06.00.45.22 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 06 Apr 2022 00:45:24 -0700 (PDT) Date: Wed, 06 Apr 2022 16:45:21 +0900 (JST) Message-Id: <20220406.164521.17171257901083417.horikyota.ntt@gmail.com> To: robertmhaas@gmail.com Cc: markus.wanner@enterprisedb.com, pgsql-hackers@postgresql.org Subject: Re: API stability From: Kyotaro Horiguchi In-Reply-To: <20220406.155332.1780268842430625734.horikyota.ntt@gmail.com> References: <20220406.143037.1305948883608926192.horikyota.ntt@gmail.com> <20220406.153153.746094489184530420.horikyota.ntt@gmail.com> <20220406.155332.1780268842430625734.horikyota.ntt@gmail.com> User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Wed_Apr__6_16_45_21_2022_948)--" Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk ----Next_Part(Wed_Apr__6_16_45_21_2022_948)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit At Wed, 06 Apr 2022 15:53:32 +0900 (JST), Kyotaro Horiguchi wrote in > At Wed, 06 Apr 2022 15:31:53 +0900 (JST), Kyotaro Horiguchi wrote in > > At Wed, 06 Apr 2022 14:30:37 +0900 (JST), Kyotaro Horiguchi wrote in > > > So if we don't want to move any member in PGPROC, we do: > > > > > > 14: after statusFlags. > > > 13: after delayChkpt. > > > 12-10: after syncRepState (and before syncRepLinks). > > > > > > If we allow to shift some members, the new flag can be placed more > > > saner place. > > > > > > 14: after delayChkpt ((uint8)statusFlags moves forward by 1 byte) > > > 13: after delayChkpt (no member moves) > > > 12-10: after subxids ((bool)procArrayGroupMember moves forward by 1 byte) > > > > > > I continue working on the last direction above. > > > > Hmm. That is ABI break. I go with the first way. > > By the way, the patch for -14 changed the sigunature of two public > functions. > > -GetVirtualXIDsDelayingChkpt(int *nvxids) > +GetVirtualXIDsDelayingChkpt(int *nvxids, int type) > > -HaveVirtualXIDsDelayingChkpt(VirtualTransactionId *vxids, int nvxids) > +HaveVirtualXIDsDelayingChkpt(VirtualTransactionId *vxids, int nvxids, int type) > > Do I need to restore the signature? For master, renamed delayChkpt to delayChkptFlags and changed it to uint8. For 14, restored delayChkpt to bool and added delayChkptEnd into a gap in PGPROC, then restored the signature of the two functions above to before the patch. Then added a new functions ..DelayingChkptEnd(). regards. -- Kyotaro Horiguchi NTT Open Source Software Center ----Next_Part(Wed_Apr__6_16_45_21_2022_948)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="v1-0001-Rename-and-change-type-of-delayChkpt.patch"