Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nc1jC-0004dp-Q5 for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Apr 2022 09:13:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nc1jB-00054W-Ne for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Apr 2022 09:13:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nc1jB-00053p-E7 for pgsql-hackers@lists.postgresql.org; Wed, 06 Apr 2022 09:13:25 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nc1j9-0001Z5-Cm for pgsql-hackers@postgresql.org; Wed, 06 Apr 2022 09:13:24 +0000 Received: by mail-pj1-x102e.google.com with SMTP id n6-20020a17090a670600b001caa71a9c4aso2120692pjj.1 for ; Wed, 06 Apr 2022 02:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:message-id:to:cc:subject:from:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=NX+tv/9T0nF5NAr6vUvdwMv5vZAQdVb36nMcrrf4n2Y=; b=P2z40ZJ76mLVgg3Om3w0agtqyQT5jIDKRilJ/ht64SBZ1aTPTlXW0JR9cCDQeKwKht 8UYOr+SSutCCXbSIMopiRQDHUT/cTRrHyKCVkOlaYhgT71c1EPD4G54AZ3OejTOyn2BZ O8wcu+S1gu9N4+J08t88BrTjGJNH9BNMhCwFxW+D1doZ+Q1EM/Q4Ssq/l2iVMF+8xhHP 59eFMg+S2O4TNdArxhSqUTc/uJcXuobpbMjZAbHBTHzc9r9n6DYijX/ZCk5y+lc2BQ1h racFBbAmDkg2Xa/tEz+srWsFhWoR99WXaYAxGirr0XQA0/KMkAtxIHeFytjHNe6yYbcl kFtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:to:cc:subject:from:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=NX+tv/9T0nF5NAr6vUvdwMv5vZAQdVb36nMcrrf4n2Y=; b=V+5FH3GIYwBByUBImPgttSc5DiAKHZlpYNtz64j+cMeJ4H9cz4Gt5NrRnrFkSUje50 x0EgTE7Z5d85YP/ayL4aD40MWsyQPRD6HsDHQGrqql3fOI8B92rkdvxaKHrVnlD16sAp vfQiNZsdSyJFgP6ZVg9W91wpDKMjLWcrrLZAjm3qpOBl+qVSxkc1oO573JbEFy4Bh1j2 T4RWteRBVY9NH9PvzeKrMYCjKSHfQitP3JyUUt725suh9u/4/dISDru/to7bNQUkf6NJ dRVVLixF9QUfwIwYM3VZ5OGMjAww9kNhbgFLRKStAY2et12VGEE/8A1kcvpbIJzy0JPT bnqA== X-Gm-Message-State: AOAM530ijlOaGPQNWvWPIlQtvp3A+vW+cFFCp9KD8PyBTR/bFsw9dE/4 /Ag8a6oC1I4TblxMToPYChU= X-Google-Smtp-Source: ABdhPJxCzP/zXyMcWwPc6K0/oXB+6rnHxegSGnucXA+uKM5wvdfP/eg32bWvL3GbJkIQGL7NNtnSNw== X-Received: by 2002:a17:902:c7d5:b0:156:878e:f876 with SMTP id r21-20020a170902c7d500b00156878ef876mr7213451pla.165.1649236402387; Wed, 06 Apr 2022 02:13:22 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id x2-20020a63aa42000000b0038265eb2495sm15582679pgo.88.2022.04.06.02.13.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 06 Apr 2022 02:13:20 -0700 (PDT) Date: Wed, 06 Apr 2022 18:13:17 +0900 (JST) Message-Id: <20220406.181317.2029659158435249356.horikyota.ntt@gmail.com> To: alvherre@alvh.no-ip.org Cc: robertmhaas@gmail.com, markus.wanner@enterprisedb.com, pgsql-hackers@postgresql.org Subject: Re: API stability From: Kyotaro Horiguchi In-Reply-To: <202204060830.gmkykqfh3b4a@alvherre.pgsql> References: <20220406.164521.17171257901083417.horikyota.ntt@gmail.com> <202204060830.gmkykqfh3b4a@alvherre.pgsql> User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk At Wed, 6 Apr 2022 10:30:32 +0200, Alvaro Herrera wrote in > On 2022-Apr-06, Kyotaro Horiguchi wrote: > > > For master, renamed delayChkpt to delayChkptFlags and changed it to > > uint8. > > For code documentation purposes, I think it is slightly better to use > bits8 than uint8 for variables where you're storing independent bit flags. Oh, agreed. Will fix in the next version along with other fixes. Thanks! -- Kyotaro Horiguchi NTT Open Source Software Center