Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nc1qw-0004y1-4y for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Apr 2022 09:21:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nc1qu-0002OK-JJ for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Apr 2022 09:21:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nc1qu-0002MI-81 for pgsql-hackers@lists.postgresql.org; Wed, 06 Apr 2022 09:21:24 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nc1qt-0003uF-2n for pgsql-hackers@postgresql.org; Wed, 06 Apr 2022 09:21:23 +0000 Received: by mail-pg1-x529.google.com with SMTP id j185so607786pge.4 for ; Wed, 06 Apr 2022 02:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:message-id:to:cc:subject:from:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=WeRcL8Rgi3x1Xb7FwL65KIFWGKVY04jRx+uXjjFQsws=; b=VNoyCo3AjyyvYaB/hGFjDaxdI/sVmSm8jCgKDpeQ05PBTBIGCcy+e7FY2NmGDpQHh+ d6kaJaeFymmW2sZhJy/tw857tkUpSrUMPJ88cSYWqIrjXAcRnKTrO9r06k3ECpumwSbF /BO1pQRWfeITqS4l/bgyuA1AeOLqQP9fxnKs7hu7Z3OVjtU6PI5xZsJ33ihO5R+z4aXP m1gOYqHgQCWs+asIb/m1JAy4TnVn2H/Fy/8qkc4BlyMbPYfnjMkx+l+JTh/sTRr5tTM1 CGTUBp39A2YkWPGUQB/VaVFiRWxkuv3668hBs/bQqc8F4U+ALzbYGieKKDi4VtFF2CXG oUKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:to:cc:subject:from:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=WeRcL8Rgi3x1Xb7FwL65KIFWGKVY04jRx+uXjjFQsws=; b=kCsoFheSHhKHFYWaK1leBR4R6b3FZAWIBrAaEMF4W/jqbNaOC+yd/9IX1g+8DW5YdC dFFSftCf+kyAvkQ5UEYqb0lFUZ4GPObJEyjH6tSlMIvQ+rvNijaTjplzQmJ6cNd4Rw7Z keplHIOWgDNWfKbvrap7Fok6Whq49ZzbBIjfWSKEYDC72kdcv58HcxzoRqNN5TwvbisS 7cgcbsaaiQf4xYgWi9xEv7+24/sg4KDjZH8NlMbQKPbuj9fMdT7h68E2pHZqtj1m5nl/ 9dDoiWA1GwbTyQOkSdSWoYXPZf90fD705IUb7SFrx8lzWkoXqmk4qiUw7g0gRC91LdVF nYFg== X-Gm-Message-State: AOAM530O/Mg3o/qsaqLYHDF/DyRlwWoIugzaSx83ancUVLYLWQs+NADw e/TINjxOfQAGVd2m5aCQgnk= X-Google-Smtp-Source: ABdhPJxzsQnOD3wFWt1+6BpnOw9fgdJ3Rr5eDZqEAsNg2ENUv68x1JOGgxFwenvA7NgVV3sl/kSdvQ== X-Received: by 2002:a63:d44e:0:b0:399:58ed:fa4d with SMTP id i14-20020a63d44e000000b0039958edfa4dmr6229672pgj.307.1649236881306; Wed, 06 Apr 2022 02:21:21 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id x25-20020a056a000bd900b004faae43da95sm17605934pfu.138.2022.04.06.02.21.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 06 Apr 2022 02:21:19 -0700 (PDT) Date: Wed, 06 Apr 2022 18:21:16 +0900 (JST) Message-Id: <20220406.182116.70086612010355256.horikyota.ntt@gmail.com> To: alvherre@alvh.no-ip.org Cc: robertmhaas@gmail.com, markus.wanner@enterprisedb.com, pgsql-hackers@postgresql.org Subject: Re: API stability From: Kyotaro Horiguchi In-Reply-To: <20220406.181317.2029659158435249356.horikyota.ntt@gmail.com> References: <20220406.164521.17171257901083417.horikyota.ntt@gmail.com> <202204060830.gmkykqfh3b4a@alvherre.pgsql> <20220406.181317.2029659158435249356.horikyota.ntt@gmail.com> User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk At Wed, 06 Apr 2022 18:13:17 +0900 (JST), Kyotaro Horiguchi wrote in > At Wed, 6 Apr 2022 10:30:32 +0200, Alvaro Herrera wrote in > > For code documentation purposes, I think it is slightly better to use > > bits8 than uint8 for variables where you're storing independent bit flags. > > Oh, agreed. Will fix in the next version along with other fixes. The immediately folloing member statusFlags is in uint8. So using bits8 here results in the following look. > bits8 delayChkptFlags;/* for DELAY_CHKPT_* flags */ > > uint8 statusFlags; /* this backend's status flags, see PROC_* > * above. mirrored in PGPROC has another member that fits bits*. > uint64 fpLockBits; /* lock modes held for each fast-path slot */ Do I change this in this patch? Or leave them for another chance? regards. -- Kyotaro Horiguchi NTT Open Source Software Center