Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncLjy-00088C-GC for pgsql-committers@arkaria.postgresql.org; Thu, 07 Apr 2022 06:35:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ncLjx-0004d0-Bc for pgsql-committers@arkaria.postgresql.org; Thu, 07 Apr 2022 06:35:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncLjx-0004ch-4q for pgsql-committers@lists.postgresql.org; Thu, 07 Apr 2022 06:35:33 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncLju-0003lh-GQ for pgsql-committers@lists.postgresql.org; Thu, 07 Apr 2022 06:35:32 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4D66E5C019D; Thu, 7 Apr 2022 02:35:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 07 Apr 2022 02:35:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=WUCZRIbeKrjf8bXztvP51cQ+OUApP0H/RsFSkn mxCYc=; b=TCBD/ucZ3IShbC96VVWGaX2DUhcmRwO4dEGx9eG2mzOdTCcPAp5CCw Vx4VxeTwaPc92Ad98iqJy33yr6qun/bKSX3H0Z6w0W+hNMo8YphX3k63CgofNN2w nwhROxUhxq6wwO3AGdWxZnxLXYztyogYweWbrxegCgA/Ea6NAlth4dzsd+0HZ9oU ++FqQcqqz5txV5wjoC6XxhXZNQ8XVmDTyZZsSswTmykshEePlcqgBLvGgPE+2Hqa jQ/SyIhAHpCS/LoYMA+eFdDG5mRjDR4R3HNb5dLkp0wAdfOjAZW5QcaOexbJ6GPC 6TBG/Tl1MmksRABJoJdJSbQNtstkOFYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=WUCZRIbeKrjf8bXzt vP51cQ+OUApP0H/RsFSknmxCYc=; b=mGRAAo7kpmJ3f9MA+eBhMMhmlYsv9+PIF 4Pfq9awoii25LgWp7VwLQyeEuSwc4pxMb/6OZLLIGWo7W8PWzSUqprZY33hZJE8z cVlrMZ6oP7Vtc4XlM5fp/PG1Ts37VQ6a5bDBId8WmyZamvsSAeS9uZJVTUHh+6q2 QCSovEoDe+8h8wYeUhHxLYRSlMpEDx8T4P26F1XPAueHdtDhFWG7H0lLgDRikx54 Bdsgqycy6zBNBtx7djI3zkOjkBWVePpTx01dXoYrkvEi3I4ogRBvrup9MGDbXPUB ucalyyoHSImEL6ZOLoVPr+CtJ0gxUrOiSY7aEGucDTM3Uy1D/MVaw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejjedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepteehheeigfdulefhvedvvddtjeehheekleetkeevgeegudeileeiudeu gfeftdejnecuffhomhgrihhnpehpohhsthhgrhgvshhqlhdrohhrghenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvshesrghnrghr rgiivghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Apr 2022 02:35:29 -0400 (EDT) Date: Wed, 6 Apr 2022 23:35:27 -0700 From: Andres Freund To: Michael Paquier Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: pgstat: store statistics in shared memory. Message-ID: <20220407063527.jdf642iuhv7vemz2@alap3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-04-07 15:09:27 +0900, Michael Paquier wrote: > On Thu, Apr 07, 2022 at 04:37:02AM +0000, Andres Freund wrote: > > pgstat: store statistics in shared memory. > > > > Previously the statistics collector received statistics updates via UDP and > > shared statistics data by writing them out to temporary files regularly. These > > files can reach tens of megabytes and are written out up to twice a > > second. This has repeatedly prevented us from adding additional useful > > statistics. > > rorqual, that uses --disable-spinlocks and --disable-atomics, is > unhappy after this commit: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rorqual&dt=2022-04-07%2005%3A47%3A03 > > test_decoding is the one complaining here, and I can reproduce the > issue locally once I build the code with those switches. Yea, saw that too. About to push the fix... Greetings, Andres Freund