Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncMcV-0002dC-B9 for pgsql-committers@arkaria.postgresql.org; Thu, 07 Apr 2022 07:31:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ncMcU-0007Z9-7Y for pgsql-committers@arkaria.postgresql.org; Thu, 07 Apr 2022 07:31:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncMcT-0007Yw-WE for pgsql-committers@lists.postgresql.org; Thu, 07 Apr 2022 07:31:54 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncMcR-0006ts-G7 for pgsql-committers@lists.postgresql.org; Thu, 07 Apr 2022 07:31:53 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4DFCC5C00EB; Thu, 7 Apr 2022 03:31:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 07 Apr 2022 03:31:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=gF8AKE8E6UbFDVEt8mBMoVyb8nIWV4mspBkNHP q9YjQ=; b=0CzrZJJ1GekH2TisyNYtzyHYThFFLdtgjMC12V6mAhvgWVXr3kGmYx ENiOLI5nB2j0a0X6M7OdcTtoyMvuQ8HXPgatclB/L2WcoThoEXL3duhyQ7PT+ALx vSzJBAT5CSDBh8VE6r244BqdMTw8Yylffyh+VyxwM/mTGN8o3Bu19wkbeBAXBf4P D1RapzBCIm5gZaa+cSmjVrUwEJWXUfZJAWvJqG1Cjz/Puf3VATVfDz4PcVDlewxd DJRHOXEp9k+18CCZ51D2ZBOS0sx7HS5Iappd54cqG7q4cCk5hYGtIkfsABdhpp+k 6suLkHYaRu29ugzFlqcF4akm9gDDSGXg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=gF8AKE8E6UbFDVEt8 mBMoVyb8nIWV4mspBkNHPq9YjQ=; b=KgTZMRh8w73Eg/58PCiBtzElwLOYc/i3f s0Lkm7qiLYRu7CDIjPjfUyIA+wCd8twyQd29qbXQJeva7IyJ+RgHV60wZYqPMZAO RRE02V+e6hKMc3nygnHsb1uvgijlXK/CwzHmB5IPN0ErdXQAuXHjZw2lEA4piQBA lckXvFPybrslYuwfwcySaO8U5oTTe+wLGHbRT2rAuK9edtCzj422e/T4gCq8etXE 5nPEloo2X3Cuz3p+x62ayPqhS6eOYlO76jWqDHCmSwkS0LaQc3F3B+vRCZ+kDW/b MJ7sNxN6b/eziGlENwhO01+HOxDkKmhROwKD5go6iPDcKlqzUlvDA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejjedguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepteehheeigfdulefhvedvvddtjeehheekleetkeevgeegudeileeiudeu gfeftdejnecuffhomhgrihhnpehpohhsthhgrhgvshhqlhdrohhrghenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvshesrghnrghr rgiivghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Apr 2022 03:31:50 -0400 (EDT) Date: Thu, 7 Apr 2022 00:31:49 -0700 From: Andres Freund To: Michael Paquier Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: pgstat: store statistics in shared memory. Message-ID: <20220407073149.qsxf74oept7o435x@alap3.anarazel.de> References: <20220407063527.jdf642iuhv7vemz2@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220407063527.jdf642iuhv7vemz2@alap3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-04-06 23:35:27 -0700, Andres Freund wrote: > On 2022-04-07 15:09:27 +0900, Michael Paquier wrote: > > On Thu, Apr 07, 2022 at 04:37:02AM +0000, Andres Freund wrote: > > > pgstat: store statistics in shared memory. > > > > > > Previously the statistics collector received statistics updates via UDP and > > > shared statistics data by writing them out to temporary files regularly. These > > > files can reach tens of megabytes and are written out up to twice a > > > second. This has repeatedly prevented us from adding additional useful > > > statistics. > > > > rorqual, that uses --disable-spinlocks and --disable-atomics, is > > unhappy after this commit: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rorqual&dt=2022-04-07%2005%3A47%3A03 > > > > test_decoding is the one complaining here, and I can reproduce the > > issue locally once I build the code with those switches. > > Yea, saw that too. About to push the fix... And rorqual seems happy again. Greetings, Andres Freund