Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncWc6-0007vt-Hs for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Apr 2022 18:12:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ncWc4-00085f-6S for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Apr 2022 18:12:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncWc3-00085W-OJ for pgsql-hackers@lists.postgresql.org; Thu, 07 Apr 2022 18:12:07 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncWc1-0001DT-A2 for pgsql-hackers@lists.postgresql.org; Thu, 07 Apr 2022 18:12:06 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id D3E333202283; Thu, 7 Apr 2022 14:12:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 07 Apr 2022 14:12:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=zl570NllvkHnd4b9lydQEdwEjw3MeTuhcR3j4g HD41k=; b=ybJSrBJxFFoetYUtCWQdpsIfii3R1WCPaqCIfbqQsAvb4bILRlv8RR Dqk4qwLLhWNZ5ckdG0YlmkIjQdKBN9/sZw+3yyhJ1DGawIJ1SZXkffKgedJyUOyk RuWW784FeA4XK/XPfS/nlAZ6Jlm0BtMz448j5h9vcdafCwLloWtWzp2hgAJE08Gp Qsa0LLCGQQidT74oD4xJWtI/YVLm7/F40heSKF18nynmHafXL5J78kSL+rb/GoMD RgvoQxt/El4XHaiYJnrq1f2LBzZML84J8q0Gf1aKVW01L+kJmAmAt+JQaDPbfRfI bCFps4p6T24G36k5rAlOvn/8yl+Xcm4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=zl570NllvkHnd4b9l ydQEdwEjw3MeTuhcR3j4gHD41k=; b=Ek3j8XsL0XaXTM7Ql2XBgs7Y0KFb1cKyi QIwqGbDBjBQytluNBF+G1j2k/To6VT8NoXN3Hk39jNuxIlPzezNVqD6OOrZyHmGo rZylGMCmzkPj348r4UIOncZReh5BXDEtzxBuSlm7gWkEiqB/qCEzGSzCowIpK/XY afHRSizBdExM6CJJ65v1YVeIZZBjcahmrPN+RoUv4olAHR6a8o1hQcLWmefLPWIF WWDkNZW+ZxK+34m+wi8RkmKPC+WR+CZ4LdwsDY8pl5H5+Yboia+8nWaNc+oUxmF+ YaTxQuk+pmxX5aPBb+gVCZAIYOCugL8n6ukeFUX75iqdeK4J/llow== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejkedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepudekhfekleeugeevteehleffffejgeelueduleeffeeutdelffeujeff hfeuffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Apr 2022 14:12:03 -0400 (EDT) Date: Thu, 7 Apr 2022 11:12:02 -0700 From: Andres Freund To: Tom Lane Cc: Michael Paquier , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman Message-ID: <20220407181202.7xa573u6e2z5dbdz@alap3.anarazel.de> References: <3385143.1649353230@sss.pgh.pa.us> <20220407175210.q44nnrvkovprxo2a@alap3.anarazel.de> <3386734.1649354265@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3386734.1649354265@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-04-07 13:57:45 -0400, Tom Lane wrote: > Yeah, with only one instance it could just be cosmic rays or something. > However, assuming it is real, I guess I wonder why we don't say > CHECKPOINT_FORCE in standby mode too. I guess it might partially be that restartpoints require a checkpoint to have happened on the primary. If we used FORCE, we'd have to wait till the next checkpoint on the primary, which'd be a problem if it's e.g. a manually issued CHECKPOINT; before shutting the standby down. Greetings, Andres Freund