Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncdVl-0004UP-8H for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Apr 2022 01:34:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ncdUl-0007uj-SK for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Apr 2022 01:33:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncdUl-0007td-HP for pgsql-hackers@lists.postgresql.org; Fri, 08 Apr 2022 01:33:03 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ncdUj-0000dn-4E for pgsql-hackers@postgresql.org; Fri, 08 Apr 2022 01:33:03 +0000 Received: by mail-pl1-x633.google.com with SMTP id c23so6655695plo.0 for ; Thu, 07 Apr 2022 18:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:message-id:to:cc:subject:from:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=gM3eXIFSVo+2sGsxFIE8xONIaLMdkNJ3vJx+7v3IBTg=; b=KAAMXlXayzwZO7SOfM3TTEWzg4VL3sUWNoTaodX/+9fCxqxMjCijfdPTPsT+8XGfz0 twbOpaza+e3uGjJZRG9Wr7V1LrZyG9Wz6rF9OnCAtbhFP0yVAUTmknH3IKXMEAE65wRa yd/7LLqlzYHDkHYNFhymfKXWeSDxXkcb2FZnNsczM/bKjw5ObuVwf8pHBzQAlXfzD+mY +lBVP+D8pMPnLLB1rV03x1qbqG66vjBHmeapHDPTZhsArngJX65NdHUC8brMHPZqNMmA L28XcCOWTuVD98zCvh6eLpH5Kn/Uv1Q4LGw7Bt9/jrNyQCY26zIRkGBcsTExQKXSyd0E 0YtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:to:cc:subject:from:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=gM3eXIFSVo+2sGsxFIE8xONIaLMdkNJ3vJx+7v3IBTg=; b=mLk7pWzPex5uqcpODSyrG+PorI6++Rq4zGvrQDutz4zOBAVNt5R9+wb0NJVUNOEIfu PVZUVfuncyXOPwVUdR80zXKosdGokOG2aOBjCTtr3lQpNvhLVSnvmzNkWaA7MRpdDCEN Yj8FwA9JBydpJeU5L20tHzlissYUNagfXHnrgBZkEfHDrN92MOI3zgDBJmKYH716DuO8 6+AzR2Gb+vuujD2M7k8tCkFcngcFw8sUUvjaB9XrvF9nH1V4vUj9awLbEWElrxPDdJei s4WTcnSndV0Ku/rgjpputh9PGl6KJF0kP3PGkzH6tz5ipQpbaDcXb/BANIZ63SWVfW/1 yekg== X-Gm-Message-State: AOAM531Ulrzb4vJjN6pF6NAHQmJDE8paEeZx8NFFChv9Eb4Z37EHO8Mx y5HDwqCOoNcNYGTtxdBIPzU= X-Google-Smtp-Source: ABdhPJzQ0kFspBK7M5co7D+zQXyEIc1qX743xhoLkDrLOSypfenSOa96JogU62SJus7RALXsslgrKQ== X-Received: by 2002:a17:90a:f011:b0:1c7:1800:a86d with SMTP id bt17-20020a17090af01100b001c71800a86dmr18980573pjb.175.1649381578808; Thu, 07 Apr 2022 18:32:58 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id o34-20020a634e62000000b0039cc4376415sm3203154pgl.63.2022.04.07.18.32.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 07 Apr 2022 18:32:58 -0700 (PDT) Date: Fri, 08 Apr 2022 10:32:55 +0900 (JST) Message-Id: <20220408.103255.1640071788970978147.horikyota.ntt@gmail.com> To: michael@paquier.xyz Cc: robertmhaas@gmail.com, tgl@sss.pgh.pa.us, markus.wanner@enterprisedb.com, pgsql-hackers@postgresql.org Subject: Re: API stability From: Kyotaro Horiguchi In-Reply-To: References: <2358496.1649168259@sss.pgh.pa.us> User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk At Fri, 8 Apr 2022 08:47:42 +0900, Michael Paquier wrote in > On Thu, Apr 07, 2022 at 11:19:15AM -0400, Robert Haas wrote: > > Here are patches for master and v14 to do things this way. Comments? > > Thanks for the patches. They look correct. For ~14, I'd rather avoid > the code duplication done by GetVirtualXIDsDelayingChkptEnd() and > HaveVirtualXIDsDelayingChkpt() that could be avoided with an extra > bool argument to the existing routine. The same kind of duplication > happens with GetVirtualXIDsDelayingChkpt() and > GetVirtualXIDsDelayingChkptEnd(). FWIW, it is done in [1]. [1] https://www.postgresql.org/message-id/20220406.164521.17171257901083417.horikyota.ntt%40gmail.com regards. -- Kyotaro Horiguchi NTT Open Source Software Center