Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njt0P-0006eK-Eu for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Apr 2022 01:31:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1njt0O-0006OG-6W for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Apr 2022 01:31:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njt0N-0006NU-TD for pgsql-hackers@lists.postgresql.org; Thu, 28 Apr 2022 01:31:39 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njt0L-00045e-2f for pgsql-hackers@lists.postgresql.org; Thu, 28 Apr 2022 01:31:39 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 013AB5C01F6; Wed, 27 Apr 2022 21:31:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 27 Apr 2022 21:31:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651109495; x=1651195895; bh=wyA3LFKAIT /jbQUbx4j0SUTP+FKyVmYUIDjc2tAt/s8=; b=2AIhmCZA+R3eCKJFj/6j2pJiI8 pCze+bkSzXE295FG7qY9UCCEXFc6cAZHCu9EK/ojOfLKQoFvDqL2dZLEAUiOO3EH jtSjEX3BaX/4isLX5WfgY/RxsUZ9kJJFKXmf41H4bTqrnGcTmhsUpeubm7TdUIzy p5I0O5PAppr1s7O426KB3riBz06DuqnGo21KCzSf1goUrZU+ASJWW0xRxGwsguz/ jFvqHHpSzoGhWS5DFI64kMZd0inc5bQg9y9wcJH2mbrLI7azsXSKjuu9GQZzZC1V Lmbbl1Y2McNU+5gWQyhbqHiHjd8mSM6K/+O0mU7zApOy7rRwlzp2O56QlHyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651109495; x= 1651195895; bh=wyA3LFKAIT/jbQUbx4j0SUTP+FKyVmYUIDjc2tAt/s8=; b=z PuQYIBkFpnphGT1lsevzNGCD/cI9TJm5l3sC8CB+tNvY/sOND5ciAxjxpZvrjqze rEPXhRPgTz5lkUwkOGAUYpVcE5/tEn8YQHDjMwaujK1fd7/h1+whzTlRdBVfacbY TUiepA5uUcVCHQaZFHi9LmaAWDta5qXU/F5UkP8je3Ix3kesRen8BY0nTbKKVce7 E6feUn4TxrmZnZPV6j+Sf9GMviXM9TlFLSc6k/j6rA1LyNdQ/8zRrEzXxiwh1OKF AuGlifvPcyMtJkhmwOTXrwchgSjolgIgtoOuOnqHin63v/lApa7LzTEGX8R0UuFE RrviLwe+p/2ntkV9RoySg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeigdegkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpeegteevjeduueduuefhfedtffehtefgvedufedtfeevgfeifefgjeduvdff geefkeenucffohhmrghinhepphhoshhtghhrrdgvshenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvshesrghnrghrrgiivghlrdgu vg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Apr 2022 21:31:35 -0400 (EDT) Date: Wed, 27 Apr 2022 18:31:34 -0700 From: Andres Freund To: Tom Lane Cc: Thomas Munro , Melanie Plageman , pgsql-hackers@lists.postgresql.org Subject: Re: Unstable tests for recovery conflict handling Message-ID: <20220428013134.gahwtxwfuu6gwfwe@alap3.anarazel.de> References: <394950.1651077914@sss.pgh.pa.us> <447238.1651082925@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <447238.1651082925@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-04-27 14:08:45 -0400, Tom Lane wrote: > I wrote: > > It's been kind of hidden by other buildfarm noise, but > > 031_recovery_conflict.pl is not as stable as it should be [1][2][3][4]. > > ... > > I think this is showing us a real bug, ie we sometimes fail to cancel > > the conflicting query. > > After digging around in the code, I think this is almost certainly > some manifestation of the previously-complained-of problem [1] that > RecoveryConflictInterrupt is not safe to call in a signal handler, > leading the conflicting backend to sometimes decide that it's not > the problem. I think at least some may actually be because of https://postgr.es/m/20220409045515.35ypjzddp25v72ou%40alap3.anarazel.de rather than RecoveryConflictInterrupt itself. I'll go an finish up the comment bits that I still need to clean up in my bugix and commit that... Greetings, Andres Freund