Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nv34u-0005UF-GL for pgsql-committers@arkaria.postgresql.org; Sat, 28 May 2022 20:30:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nv34t-0004p2-1N for pgsql-committers@arkaria.postgresql.org; Sat, 28 May 2022 20:30:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nv34s-0004no-Pf for pgsql-committers@lists.postgresql.org; Sat, 28 May 2022 20:30:26 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nv34o-0002lK-Oz for pgsql-committers@lists.postgresql.org; Sat, 28 May 2022 20:30:26 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 1CFD43200657; Sat, 28 May 2022 16:30:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 28 May 2022 16:30:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1653769819; x=1653856219; bh=PZaR3Am50l wFkF/IlOasNsqP7GxBFNrkDw36fMvhNBY=; b=FdJxIGlkzE8zR7OW/SKC+r6KqB oxZvve+NypGujOeqNevn6j+p/629lZ02FDI0yAZ4HshwRNMjjppG3gRKnIJCkbfG WpJ2iASqbXC6KZWHRXQ/c9Ndvyzd/GHierccMB36LIxIiP1wpuqVIXPkwIRu9rHV eJ5Fz4/oitD415OyOxqA0vwZ8RDldKmNRrF7/3RbB8RLfOYkGgghyMb2JJxNs7TR LrHS/65MHTYoauVo5vDhsPERNP+XoKqw0hJwNTs7l4oZs0bAkjDjRotkXStEU0ve 2pSHg0kKQsIECSQ7zjwavAuyPM/Ou2c9UplZblm5aFo9s+9gKfLsIkq9VQdg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653769819; x=1653856219; bh=PZaR3Am50lwFkF/IlOasNsqP7GxB FNrkDw36fMvhNBY=; b=uldddIFYdk0muxxTxLjIvuiNwOVNYRwaf+W0AlwyzATx RBGjf3vbiHKVL95X6DM08mXhrOwuIwZYyae0wBVNCfmd2urnLJXgqQ9+pD1RYclF KVhHyEBKbJ10diFfPvHuoy76dZbLYGdoJGiVoA1OXGf9+j//jpTiKNKBTWoXDs24 cn9hi7UJ81N+5iuj7WQdJ2LDEADiI7lOcWjUqjXA1wNjsCHUBsO/xYLiiVCZzr7q 2Q4lcZ052MDqcDfdGthoQ5AGyFo+SDI6RLR+llglMB/dP36FZhRUAGfgSXeMxJxI faT/iJxol2rWH5X/7vh1ONexjSBnbUcDeodnIn3CBA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrkedugdduhedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepvdfffeevhfetveffgeeiteefhfdtvdffjeevhfeuteegleduheetvedu ieettddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 28 May 2022 16:30:18 -0400 (EDT) Date: Sat, 28 May 2022 13:30:17 -0700 From: Andres Freund To: Amit Kapila Cc: Tom Lane , Amit Kapila , pgsql-committers Subject: Re: pgsql: Extend pg_publication_tables to display column list and row filt Message-ID: <20220528203017.l623lrc2ak45xry6@alap3.anarazel.de> References: <91075.1652929852@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-05-19 08:59:13 +0530, Amit Kapila wrote: > On Thu, May 19, 2022 at 8:40 AM Tom Lane wrote: > > > > Amit Kapila writes: > > > Extend pg_publication_tables to display column list and row filter. > > > > Is this really something to be doing post-beta1? > > > > I am sorry if we don't allow to make catalog changes post-beta1. I don't think there's a hard prohibition of catalog changes. But we should be careful doing them because it makes testing more painful etc. > If we can't do that then I can revert this and try to find a different > solution to the problem? What "problem"? This just seems like a feature in a problem's clothing? The commit message says: > This information will be useful to users and we also need this for the > later commit that prohibits combining multiple publications with different > column lists for the same table. which doesn't at all strike me as a justification for committing it post feature freeze, i.e. it sounds like a feature. If you want to argue that it's a rough corner in v15 work, that it's worth committing now, do that explicitly. Greetings, Andres Freund