Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBKjF-00017P-2L for pgsql-committers@arkaria.postgresql.org; Tue, 12 Jul 2022 18:35:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oBKjD-0005bn-TM for pgsql-committers@arkaria.postgresql.org; Tue, 12 Jul 2022 18:35:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBKjD-0005bV-Lv for pgsql-committers@lists.postgresql.org; Tue, 12 Jul 2022 18:35:23 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBKjA-0003p6-Ux for pgsql-committers@lists.postgresql.org; Tue, 12 Jul 2022 18:35:23 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 26F89320085B; Tue, 12 Jul 2022 14:35:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 12 Jul 2022 14:35:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1657650917; x=1657737317; bh=b QsCBwQxuspHYXDgJJrtioJ3iwsI1/9uKgl5nOfEGtg=; b=lxx7ApLFFHKaatJU6 aVkMouBRnxArkVAUbFDge+hyMR9YrgsUh5CcOdUPXhfRGEaMgF/4nYOthuxbzpId 6PQuHC9Q14D5fx6/NNMMay3MK/XO55QJosZtTo001fdroSn9amRZu0YyIq1vLz6O d5SPY5jtBa8GYD2ktzCVReqU48rQikHQJmo3JPSvnPVeXCSTVgw3BU0mw5QKPuBC r/SZUHQsD5mJynbIkmJ5EZbdg6TnOshhq8fbcO6LbaXf/+h7kUFYJvaxz7CqR0Cm sK4Ew3lnEqtqsHCTDBim7Ac1Xjhr33YAFRsJA3ZRh5Iy+IY6fyTq1561cqDpyMN3 ZOUxQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejhedguddvlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkgggtugfgjgesmh ekreertddtjeenucfhrhhomheptehlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvghr rhgvsegrlhhvhhdrnhhoqdhiphdrohhrgheqnecuggftrfgrthhtvghrnhepudelkeekgf dttdettdekgfduvdeiffelteegjeeihfetheekveeftedtuddvhfeunecuffhomhgrihhn pegvnhhtvghrphhrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdho rhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Jul 2022 14:35:17 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 8B4A9369; Tue, 12 Jul 2022 20:35:16 +0200 (CEST) Date: Tue, 12 Jul 2022 20:35:16 +0200 From: Alvaro Herrera To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Add copy/equal support for XID lists Message-ID: <20220712183516.cmdowamk7eqahmjw@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="oc7di7olfo6fqszi" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1548311.1657636605@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --oc7di7olfo6fqszi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On 2022-Jul-12, Tom Lane wrote: > What about outfuncs/readfuncs? I see that you fixed _outList, > but not its caller outNode: > > else if (IsA(obj, List) || IsA(obj, IntList) || IsA(obj, OidList)) > _outList(str, obj); > > and the LEFT_PAREN case in nodeRead() doesn't know what to do either. Hmm, true -- naively grepping for OidList wasn't enough (moreso when I failed to notice one occurrence). This patch closes the holes you mentioned. I haven't found any others yet. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "La vida es para el que se aventura" --oc7di7olfo6fqszi Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Fix-XID-list-support-some-more.patch"