Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBX3Z-0004vP-53 for pgsql-committers@arkaria.postgresql.org; Wed, 13 Jul 2022 07:45:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oBX3Y-0003nL-2e for pgsql-committers@arkaria.postgresql.org; Wed, 13 Jul 2022 07:45:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBX3X-0003nC-SR for pgsql-committers@lists.postgresql.org; Wed, 13 Jul 2022 07:45:11 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBX3U-00025I-Tm for pgsql-committers@lists.postgresql.org; Wed, 13 Jul 2022 07:45:11 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 6E1CF320095E; Wed, 13 Jul 2022 03:45:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 13 Jul 2022 03:45:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1657698305; x=1657784705; bh=f Ukh0kmRl8XCWpEZhSNYfWbU/gt0Vmp76iF8Cl23wpE=; b=A3+4XnxjahenJd3Wv XpXAMP2nD6BDoH+9RtYKJayHIHE3oh06Ca+wPrckcfN9jbjJX2MsHN8NAhLWr8c0 GkQL2CDFmumqfpxlfFVouVfKKfmkxJX1hU1qRNI1la/OiChhU7QRadgPgu3ER0cV KWgcbaUPCAFjeRRzpvO0/1MjVoAFwssR+Nwoxc825Y8a3s8dP3RonjbwK3n6P0pB jf5L6xYoi64r8QTD/YwDOsV7nmybvOoQbjdI0ZiOgkcGNqFWPH3OqgZuXLPArM9i 0n6EzMKX6iPvYOmi/AjgdQTmcjLNL1owppzbFw/APc0PREJSX86yKydwmrghE/UQ IxNpg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejiedguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhv rghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorh hgqeenucggtffrrghtthgvrhhnpedvkedtffduffdtffffheffhfejjefhgfeiueeukeej keffgfdufffhudffffeuveenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtoh hmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghl vhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Jul 2022 03:45:05 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id C58D9369; Wed, 13 Jul 2022 09:45:04 +0200 (CEST) Date: Wed, 13 Jul 2022 09:45:04 +0200 From: Alvaro Herrera To: Peter Eisentraut Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix for make unportability Message-ID: <20220713074504.wknclwsjlvbz4edl@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Jul-13, Peter Eisentraut wrote: > Fix for make unportability > > 88dad06b47eb80f699211c9b0b7a1c6d9016ad19 contains a make $(shell) > construct that apparently confuses older GNU make versions (possibly > because of the # inside the shell command?). This construct, which > would allow # comments inside LINGUAS files, was adapted from gettext > recommendations, but we don't actually need that functionality, so > sidestep this whole issue by just using plain "cat". I suppose if we're getting rid of Make soon, it's not really very useful to make this more make-ish: AVAIL_LANGUAGES := $(file <$(srcdir)/po/LINGUAS) -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/