Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDG6C-0003z2-2i for pgsql-committers@arkaria.postgresql.org; Mon, 18 Jul 2022 02:03:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oDG5C-0007Gk-Ul for pgsql-committers@arkaria.postgresql.org; Mon, 18 Jul 2022 02:02:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDG5C-0007Ga-P4 for pgsql-committers@lists.postgresql.org; Mon, 18 Jul 2022 02:02:02 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDG59-0005op-73 for pgsql-committers@lists.postgresql.org; Mon, 18 Jul 2022 02:02:02 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1B37D5C00A6 for ; Sun, 17 Jul 2022 22:01:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 17 Jul 2022 22:01:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658109717; x=1658196117; bh=uUJpXJspOW yl7WDTSy3Pq0/v7IG0/g8XJxpT5XWT+Mw=; b=nm9oJ7U1BEQW/2HhagJwEKejeX BQ9dt+DAyyevwh6NMHoGpA3Yd7WJdbM/3v5zguAqXBxbN2CpvM99IkP+t9yreaNB SGI364vHxmAO1VhtG3gj5qz+dWmKiBei+J7Of/CJv2X0uTetABBnm0hAChN7cWb6 uRDxpc/msJ9V9Li2dIEQTYpRrzZwQP1z++81jjtM0j6SgboIBlf/F1bgI92X9mog DUrIGPqBPPkZvLneXV2W8WUowyr6Gp492R9h5pOatjM7fy//36XQG7XgPFEZbAwt PFKuq2vVbg4ucqZZ/85vX7ajqndG9T6Dxnhvf9oWzimAzePE4SFhVdo+5pLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658109717; x=1658196117; bh=uUJpXJspOWyl7WDTSy3Pq0/v7IG0 /g8XJxpT5XWT+Mw=; b=Jum9/FjQGWIc7cocoBVnGDMpbqWjq1RjrMkwgcf7dgly UkHscXSmXLJPpAAHcm9NqzyC1IDY/6xGwWOsFETg8/jf5gFwe2BR4lZqMoLSlfT4 lYb+NpXw4mX22Srn321/BASkerR3fLD5YG8Cc4cKEgzSak56YLt1hmhUvrNjst81 JjhGc6nIOBHT4T6UIB4ynL6UsCXeP27+EMVY8h1muUFh2ZmQpDfMty83tvMOvrLS 196UTXMu08SuZvaH/SZ2vMpNjvYhbudx1M56kXx9dC7CpqT2fUPYSM9d9XVNcgEf KsTh+IHzV0++pFKhlD+xJjiWLAlPEGCo/R2kpip55g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekjedgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomheptehnughrvghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghn rghrrgiivghlrdguvgeqnecuggftrfgrthhtvghrnhepudekhfekleeugeevteehleffff ejgeelueduleeffeeutdelffeujeffhfeuffdunecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomheprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sun, 17 Jul 2022 22:01:56 -0400 (EDT) Date: Sun, 17 Jul 2022 19:01:55 -0700 From: Andres Freund To: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi Message-ID: <20220718020155.s2soi3niln2skjwi@awork3.anarazel.de> References: <20220718013934.27ukvatuxneyrr2v@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220718013934.27ukvatuxneyrr2v@awork3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-07-17 18:39:35 -0700, Andres Freund wrote: > On 2022-07-18 01:05:56 +0000, Andres Freund wrote: > > Default to hidden visibility for extension libraries where possible > > Looking at the odd failures, not sure what went wrong. I don't know how the configure exec bit got removed, shell history doesn't show anything odd in that regard. I do see a mistake in locally merging the symbol-visibility branch (leading to a crucial commit being missed). I do see in shell history that I ran check-world without a failure just before pushing, which should have shown the failure, but didn't. Definitely a brown paper bag moment.