Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDZcq-0002tf-W1 for pgsql-committers@arkaria.postgresql.org; Mon, 18 Jul 2022 22:54:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oDZcp-0007aj-GT for pgsql-committers@arkaria.postgresql.org; Mon, 18 Jul 2022 22:54:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDZcn-0007Wd-QG for pgsql-committers@lists.postgresql.org; Mon, 18 Jul 2022 22:54:03 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDZci-0001qr-4j for pgsql-committers@lists.postgresql.org; Mon, 18 Jul 2022 22:54:01 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 79C8E32008FB; Mon, 18 Jul 2022 18:53:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 18 Jul 2022 18:53:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658184831; x=1658271231; bh=FSrzpCEtcP hOsV8dTZnnce+yFNCBC9MgWQ9UezG6uu8=; b=hFe6Bb+QvjHTIgn/ikSCjP+wKD QtXNyGuZG0zSE6GqKio9NCynmgUbmaK2oR0SVQ3aChqT16tE5Xn6H/1/vLSfK+Ci KjmlWDBgwzm9h1eeX8jPUKZFodCBmcDWgJyOJ4EmLOWKrQb323AguyuUX78EH23l 2i7Vf8Sp9+c+z5l1J+gcRkjjEQVVrGsOPU5aJNFa4H7ll1GKMMEv0aHxfkZUZZ7a UVDciGplZy6Fkk+rnO+w+dJQ0pn6rbSM/ZOImYvyvp86kcaMDkHg04cqdtXKtIu7 PMpQ5ALvRvtymN3J+u9KNuu+wOK8jvOTCQAs/uIDRQ/BOhfq7ioTZNEe+uAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658184831; x=1658271231; bh=FSrzpCEtcPhOsV8dTZnnce+yFNCB C9MgWQ9UezG6uu8=; b=VLZr/AA11G6+i7i5bfzpc61+alCfXSsB186ZRfWwo0OX lHaa+QUab7R7QUY6Dxm4n/M0ers2VsT282K9cq8mXO4CLO6eO1Gfv3nrADkCkf/P pSYSJjCj25p9b/rGcHw3H88mhOdkJ34ESHKNQF8kyn/ShLARenKc3T5hXFitwEVM ss+RLAFEbMCIhedxSqppQiI96w5hzDcor3krqINqBpCPAVIPgq9Xamb2ISMk6DkF /lMR6nRgskijK/oegZvRqZnZqTJLrJFydSizBeSHOO2z/Hz4ChpImNBIbHpUdSIW e61LjZGqRxRLRdeLHvSuyz+i1dylJJhmmICeeTlTEA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekledgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepvdfffeevhfetveffgeeiteefhfdtvdffjeevhfeuteegleduheetvedu ieettddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 18:53:51 -0400 (EDT) Date: Mon, 18 Jul 2022 15:53:50 -0700 From: Andres Freund To: Tom Lane Cc: pgsql-committers@lists.postgresql.org, Andrew Dunstan Subject: Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*. Message-ID: <20220718225350.chv7urtdre4jnnqk@awork3.anarazel.de> References: <20220718211408.o2uyu5kvud56ihlj@awork3.anarazel.de> <822625.1658179641@sss.pgh.pa.us> <20220718215042.sl3hivoupdb7lkwv@awork3.anarazel.de> <838180.1658181982@sss.pgh.pa.us> <20220718221535.bf43zwf5rf2wi4wd@awork3.anarazel.de> <840982.1658182844@sss.pgh.pa.us> <846745.1658183810@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <846745.1658183810@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-07-18 18:36:50 -0400, Tom Lane wrote: > I wrote: > > Andres Freund writes: > >> Grepping for 'no warnings' shows that check_rules.pl has the same > >> issue. Perhaps worth fixing at the same time, given how closely related they > >> are? > > > Ah, I didn't think to look around. I'll see what I can do there. > > Oh, that one's only hiding *one* sloppy spot. However, while testing > it I realized that the Makefile rule has two serious deficiencies: > > * check_rules.pl not listed as a prereq, so nothing happens if you > change it and say "make". > > * check_rules.pl should be run first. As-is, if it complains, > preproc.y has already been updated and so another run will succeed. Good catches. > You might wanna check your meson conversion for the same bugs. Don't think it has. check_rules.pl and parse.pl are run by separate build rules, with a stamp file marking the success of check_rules.pl. However, they can currently run concurrently, with the preproc.c generation depending on both. I guess it'd be a tad cleaner if the dependency instead were to run check_rules.pl before parse.pl, the degree of parallelism probably doesn't matter here. Both rules depend on the scripts. Greetings, Andres Freund