Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDn74-0008WQ-Ar for pgsql-committers@arkaria.postgresql.org; Tue, 19 Jul 2022 13:18:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oDn73-0001h1-2q for pgsql-committers@arkaria.postgresql.org; Tue, 19 Jul 2022 13:18:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDn72-0001dQ-S6 for pgsql-committers@lists.postgresql.org; Tue, 19 Jul 2022 13:18:08 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDn6z-0000gr-WE for pgsql-committers@lists.postgresql.org; Tue, 19 Jul 2022 13:18:08 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 311005C00D0; Tue, 19 Jul 2022 09:18:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 19 Jul 2022 09:18:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1658236684; x=1658323084; bh=R +d5pSSQr9lzz2DO3okR/BGxt1WzdmOfEXoSEsK/62Q=; b=ls4pCG184bmp+eEc7 sghD9jnhrssDgSYupXaSHfRUmoek9XqOPvEt0C7p7zdTn0iH3hO+umRHTFx3mr4+ eoR4CZRQvUvkKEM+56THN+IFVMN9M3IdBzZ5kH1fKwuLgjhBXu78CIEdkx00t98l ASCvrbR754pe1vvvITWuf9MlAlKd9VwpuRcCYgtL8gN/TtmAbC80/LHFVjWlPjAS TisG0LSVWfHSwqHCeQ2QwIUmxLFtEa5U+nOPZ7FGz2EE0Jj5PVcKpVE7RFIRvdt8 I1M4xd1bjWfDhQiQnUtIZils0eDmEbLTnryAqbvdAx9nxgxhfEoQ+2BC29yWQa4/ pvhVQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeltddgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Jul 2022 09:18:03 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 3E845369; Tue, 19 Jul 2022 15:18:01 +0200 (CEST) Date: Tue, 19 Jul 2022 15:18:01 +0200 From: Alvaro Herrera To: Pavel Stehule Cc: Andres Freund , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi Message-ID: <20220719131801.xltj7tupafzkj5dx@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Jul-19, Pavel Stehule wrote: > po 18. 7. 2022 v 3:06 odesílatel Andres Freund napsal: > > > Default to hidden visibility for extension libraries where possible > Unfortunately, this commit definitely breaks plpgsql_check. Can the > following routines be visible? Do you just need to send a patch to add an exports.txt file to src/pl/plpgsql/src/ for these functions? plpgsql_build_datatype plpgsql_compile plpgsql_parser_setup plpgsql_stmt_typename plpgsql_exec_get_datum_type plpgsql_recognize_err_condition plpgsql_ns_lookup -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/