Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDpCe-0004Te-2h for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Jul 2022 15:32:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oDpCb-000710-P3 for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Jul 2022 15:32:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDpCa-0006uw-Mh for pgsql-hackers@lists.postgresql.org; Tue, 19 Jul 2022 15:32:01 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDpCU-0004Is-2m for pgsql-hackers@lists.postgresql.org; Tue, 19 Jul 2022 15:31:59 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4FE083200754; Tue, 19 Jul 2022 11:31:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 19 Jul 2022 11:31:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658244711; x=1658331111; bh=Ef6yqKOJCq XtmFYIehKKGunmujxRRVKFSJLtL7x/JJQ=; b=PYCws033yOGRsuRHIRO5W733mu Dgw42Q7psmU/DryAgn4y7/Vqunm8Dqhb21JOWfzXZWlJ5+lJGop7CpXi1EWLtxDJ s6dyHwzqSz729zStbXgx5jbdLs+3CxFXKxMtBdxEJscaVJ1ZiEDoQu70YBsVRpGM nI/ZKJJWzTO5NksLUPasCwJjkX/hHFUkYXd02YZ/B8TAgh9kSM16RT3nnMdXALpI RaTcyFhVKWqumihAtZYNuIT4E2q00GyELKi/gPNjNJWmPw5JjXzXOOlnEzM9B6Tp RT6BHC47VtqCz4NJQhBR96JC5N7n8k4H0EzKz4uMnBE2XTJn9C633HU8b1Kg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658244711; x=1658331111; bh=Ef6yqKOJCqXtmFYIehKKGunmujxR RVKFSJLtL7x/JJQ=; b=phEKW9rZm91r0LUcQShafHFkreCRIXJ2+/3Hl4c8dtpj lNhsVTuB9aymB6mglpgOZEjiPejruO/7f4x4YVM+N8RfT4Sg6hb//rtIwMQEiFCe ZJD85M4zoWixl40DPsUauj8q3xLWM/l4gHLcptUen+eS2Z4PYscVA3IDKxCE8Vca CW5Yc8qGuilFwWLPpmLfCZOpIMRWeZyp0Mv3Q10RJX1xUHjBzN4dWWLwIdUgR+Hl 8ka6UpHSlBhHKfGNbl+I0y3IL5+G/0OzPUqYyX1mfWN7gZdNIIg3R77Msg6uD4mB dRa/sTnFPKHj0/wZENZZt+Szxeq4/ZCvoA1lGPVG6g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeltddgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepvdfffeevhfetveffgeeiteefhfdtvdffjeevhfeuteegleduheetvedu ieettddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Jul 2022 11:31:50 -0400 (EDT) Date: Tue, 19 Jul 2022 08:31:49 -0700 From: Andres Freund To: Alvaro Herrera Cc: Tom Lane , Pavel Stehule , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi Message-ID: <20220719153149.lhbir3wh4sgfkfe7@awork3.anarazel.de> References: <1057666.1658238352@sss.pgh.pa.us> <20220719142807.2zex4cczycc5nqq5@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220719142807.2zex4cczycc5nqq5@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-07-19 16:28:07 +0200, Alvaro Herrera wrote: > Anyway, the minimal patch that makes plpgsql_check tests pass is > attached. This seems a bit random. Maybe it'd be better to have a > plpgsql_internal.h with functions that are exported only for plpgsql > itself, and keep plpgsql.h with a set of functions, all marked > PGDLLEXPORT, that are for external use. It does seem a bit random. But I think we probably should err on the side of adding more declarations, rather than the oposite. I like the plpgsql_internal.h idea, but probably done separately? Greetings, Andres Freund