Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEAJb-0005TP-4M for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Jul 2022 14:04:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oEAJZ-0002W7-LP for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Jul 2022 14:04:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEAJZ-0002Vx-CD for pgsql-hackers@lists.postgresql.org; Wed, 20 Jul 2022 14:04:37 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEAJW-0006a9-Ss for pgsql-hackers@lists.postgresql.org; Wed, 20 Jul 2022 14:04:36 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 8C1B432000F9; Wed, 20 Jul 2022 10:04:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 20 Jul 2022 10:04:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1658325873; x=1658412273; bh=J GntG96ESn+Q+UieEvZKkpy4piqCVpr3HnoB4IGksxE=; b=n45BTwNMhyEAIEktB NbjJeeJttLzOV84XqVLHKQK60IFgIUC9i0uHPYIGwy/GoT4uzN5tvFKqg9Zk/Zag 3E7CpLImtjVz4lC9NP4oJ7VXKgq07mC2P3DkL6oH96Y0dQGhxYctwOybRXt8FH9F eFvD4YVBqcpF+KZWmXKRed8CrJWN9VKP+RjkVhHPMuULBl1io5+UTnFJi6/cyISX E+ODvddSsoz6dkmvS3S4AH877fuAedGMCME7XyMTy7lN2dtiqI2lYdpPfV6BeGnV Bx88Y1i+f4ia1jKoTRHwMdDOJUeIUCSQeSxm8PVsCUZ7LXEe8JPO8asxf1+qE+BK zg4oQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudelvddgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Jul 2022 10:04:32 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 0F6FC369; Wed, 20 Jul 2022 16:04:30 +0200 (CEST) Date: Wed, 20 Jul 2022 16:04:30 +0200 From: Alvaro Herrera To: Tom Lane Cc: Andres Freund , Pavel Stehule , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi Message-ID: <20220720140430.2s6nyy5s6b4rpu23@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1691356.1658324330@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Jul-20, Tom Lane wrote: > I'll try to do some research later today to identify anything else > we need to mark in plpgsql. I recall doing some work specifically > creating functions for pldebugger's use, but I'll need to dig. I suppose you're probably thinking of commit 53ef6c40f1e7; that didn't expose functions directly, but through plpgsql_plugin_ptr. Maybe that one does need to be made PGDLLEXPORT, since currently it isn't. That was also reported by Pavel. He was concerned about plpgsql_check, though, not pldebugger. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ Bob [Floyd] used to say that he was planning to get a Ph.D. by the "green stamp method," namely by saving envelopes addressed to him as 'Dr. Floyd'. After collecting 500 such letters, he mused, a university somewhere in Arizona would probably grant him a degree. (Don Knuth)