Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGm2L-0002eJ-Oj for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Jul 2022 18:45:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oGm2K-00084K-Hq for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Jul 2022 18:45:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGm2J-00084B-Gx for pgsql-hackers@lists.postgresql.org; Wed, 27 Jul 2022 18:45:36 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGm2E-0004xS-EN for pgsql-hackers@lists.postgresql.org; Wed, 27 Jul 2022 18:45:35 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D6C0D5C00EB; Wed, 27 Jul 2022 14:45:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 27 Jul 2022 14:45:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1658947526; x=1659033926; bh=B 5UJayQ4g2fSAWXW0BAqkIpaZKJUPdrZ+2q3LKuknKg=; b=PPJ/BmbvBt8NRhDMX MlEkyf0dtlIZpNh+iwBuLvgFsfSpXiCxIaR4T7AoqmVwi6k9a5VAkfCRouXi8WCE 8iE5E7UMOoqJBAszzc/yy6rXrsReKqO+qi3Xc8rWwMPJ8gR47N0OInF+4x06gOY1 Rsvv/JSKMQnWnMfN/PW+I9/RDxoYVaIzmL7lAmEsdmpRCXgxQ8PtPOsASraLPURV WaIT0dAKVUWNx0Dm62tyvBenJjRZ6Zh2ZvQPM2ab3PeNkKxHHUdc4W7U/segDULW z6BqI/zOEEYw8JgsBza/hPptluJ4HqsZqwrl/ZBQnrYhXrkWFkaP9R0ECUVjQXkE ygWIw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdduvddgudeftdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhv rghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorh hgqeenucggtffrrghtthgvrhhnpedvkedtffduffdtffffheffhfejjefhgfeiueeukeej keffgfdufffhudffffeuveenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtoh hmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghl vhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Jul 2022 14:45:26 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id CBE0B372; Wed, 27 Jul 2022 20:45:23 +0200 (CEST) Date: Wed, 27 Jul 2022 20:45:23 +0200 From: Alvaro Herrera To: Robert Haas Cc: Tom Lane , PostgreSQL Hackers Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes. Message-ID: <20220727184523.n7emhydwhnegd2ci@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Jul-27, Robert Haas wrote: > Hmm, but that doesn't actually produce nice behavior. It just goes > into an infinite loop, like this: > 2022-07-27 14:21:12.869 EDT [32853] FATAL: relation mapping file > "global/pg_filenode.map" contains invalid data This seems almost identical what happens without the version number change, so I wouldn't call it much of an improvement. > While I agree that changing a version identifier that is more closely > related to what got changed is better than changing a generic one, I > think people won't like an infinite loop that spews messages into the > log at top speed as a way of telling them about the problem. > > So now I'm back to being unsure what to do here. I vote to go for the catversion bump for now. Maybe it's possible to patch the relmapper code afterwards, so that if a version mismatch is detected the server is stopped with a reasonable message. An hypothetical improvement would be to keep the code to read the old version and upgrade the file automatically, but given the number of times that this file has changed, it's likely pointless effort. Therefore, my proposal is to add a comment next to the struct definition suggesting to bump catversion and call it a day. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/