Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJBtv-000464-HY for pgsql-committers@arkaria.postgresql.org; Wed, 03 Aug 2022 10:46:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oJBsv-0003UN-Ea for pgsql-committers@arkaria.postgresql.org; Wed, 03 Aug 2022 10:45:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJBsu-0003PG-HY for pgsql-committers@lists.postgresql.org; Wed, 03 Aug 2022 10:45:53 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJBsp-0003lh-5J for pgsql-committers@lists.postgresql.org; Wed, 03 Aug 2022 10:45:50 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A1EBB5C00D4; Wed, 3 Aug 2022 06:45:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 03 Aug 2022 06:45:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1659523541; x=1659609941; bh=K uWhlBzP0+XGAI72u3o+qpyc1zDX48y2iF4g/yfdWuo=; b=yeArYpri/QjO8cBw3 k6ZLim1clqCioZvd+V78oiG/GOBBcWvYrxBZqyc8aB5zGVBFZGi6zAtsIE5OqcVC 4WsXzbWb7rB/0YhwVoWqeH9+v5Kp5C607ti8iXFk3TdzU+Z9Cj/TbS83sn82jed/ O6B+ALSZF9tqba2iGrnPMrq4fLkWiHJW30Yh8U7BAMleZfm437if64tULY6trjul NDWbTtZxNlJl5Q2ehO15O6cafBetcErv7k52dXIejmkfkxlRzYcaPzlwfePz07QA /H6ZVpXLBYkLd44eLeQIMGOcIq1sblbEZ0A0Ns78FK0InFM4CVrswK0JW+kkR0UG WBxuw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddvjedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepgfdtgeelgefgffdtieduudffhfevkefgudefteehgfet hfekvdegjeelhfethedvnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh dpphhoshhtghhrvghsqhhlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomheprghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 Aug 2022 06:45:40 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 55893373; Wed, 3 Aug 2022 12:45:44 +0200 (CEST) Date: Wed, 3 Aug 2022 12:45:44 +0200 From: Alvaro Herrera To: Amit Kapila Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Add wait_for_subscription_sync for TAP tests. Message-ID: <20220803104544.k2luy5hr2ugnhgr2@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Aug-03, Amit Kapila wrote: > The new function wait_for_subscription_sync() can be used to replace the > above code. This eliminates duplicated code and makes it easier to write > future tests. Hmm, if you don't backpatch this, it might become a hurdle if we later backpatch tests that use it. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "I can see support will not be a problem. 10 out of 10." (Simon Wittber) (http://archives.postgresql.org/pgsql-general/2004-12/msg00159.php)