Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJzuR-0003JL-00 for pgsql-hackers@arkaria.postgresql.org; Fri, 05 Aug 2022 16:10:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oJzuO-0000aB-Pi for pgsql-hackers@arkaria.postgresql.org; Fri, 05 Aug 2022 16:10:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJzuO-0000UR-Fj for pgsql-hackers@lists.postgresql.org; Fri, 05 Aug 2022 16:10:44 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJzuH-0002Od-J3 for pgsql-hackers@lists.postgresql.org; Fri, 05 Aug 2022 16:10:43 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 55835320093E for ; Fri, 5 Aug 2022 12:10:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 05 Aug 2022 12:10:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1659715835; x=1659802235; bh=WmWd1P7K4cfS8 hcLkWlDy06Ppoicbuc+BwkviTqR9k4=; b=Gz7Aa7tBrv77sZw2UzP1LK7bE9o5W A4ESujg+yD/cm+64CU/qGjK4aknWNc9+F/FgTvO91nqhayGbzxbBOBkBG5SnIQvs 7WPFtpQMNeoWT+byR7p512XSzqml2Vi2i8ZIyuVa5Pv2euKExGYT8do9n4LfVoaH Cwnia+AFMV72/yvpR9vLzn4CWKMCuTVzfQxUW+23kBYQxVdw75oJSACbB9WTyCvR x5+zELs96hx338PwLxSIirOQSfoxInQSXMqvZkPObUbn4N/6SQ/3myuiiNSihx8K UOnIqdQNVunqeMAA2KmQ4d5CUKo6kUtbEdW5d03y4q4y5Huw8AsYLCtbQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdefuddguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfggtggugfgjsehtke ertddttdejnecuhfhrohhmpeetlhhvrghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhr vgesrghlvhhhrdhnohdqihhprdhorhhgqeenucggtffrrghtthgvrhhnpedujeevjeffje evuddutedvkeeiueeitddvieelfeekveejudefgeeuvdejhfeuleenucffohhmrghinhep vghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhr gh X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Fri, 5 Aug 2022 12:10:35 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 0C45D373; Fri, 5 Aug 2022 18:10:43 +0200 (CEST) Date: Fri, 5 Aug 2022 18:10:43 +0200 From: Alvaro Herrera To: pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Message-ID: <20220805161043.nsbxv565k4q453no@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Aug-05, Alvaro Herrera wrote: > Add a test that tickles the case, as branch testing technology allows. One point here is that this confirms that the backpatched renaming alias for PostgreSQL::Test::Cluster is working well. Another is that, as far as I know, this is the going to be the only case of any code being run under wal_consistency_checking=[not off] regularly. 027_stream_regress.pl is equipped to do so, but as far as I know we have no buildfarm animal with PG_EXTRA_TESTS set it so. I did consider to make this new test conditional on having that flag be on, but I disregarded it because of that. A third point is that in branches 15+ I made it use pg_walinspect to ensure that the desired WAL record is being emitted. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/