Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLmIt-000871-Vb for pgsql-committers@arkaria.postgresql.org; Wed, 10 Aug 2022 14:03:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oLmIs-0007sa-JO for pgsql-committers@arkaria.postgresql.org; Wed, 10 Aug 2022 14:03:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLmIs-0007sR-C5 for pgsql-committers@lists.postgresql.org; Wed, 10 Aug 2022 14:03:22 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLmIp-0007b0-Vc for pgsql-committers@lists.postgresql.org; Wed, 10 Aug 2022 14:03:21 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E181B5C0198; Wed, 10 Aug 2022 10:03:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 10 Aug 2022 10:03:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1660140198; x=1660226598; bh=E JB5Iiu5qKDVUdMxFivumY5rS6BIWSXlu1UQCJSBGGo=; b=i5MfsbdH9zxa8/W4/ u2dHAlV3DpmIjHGC+INPQ6EZRVg2fwqlhJqFIDPdrpQXkd0Ng8EwLLo/oPvy1+at Vu3jESSf5NQjf9gaGZ42lp+nx0k5XabKS4VuG72XrFxMDDMxiquU7T/pDtjZBC5C 7hadv2nqu2rGD88yN+nW3EGDvs9xNyvI3w1ufhMMHfedqRx4IctIJGYSj+LznzBF +hS4vTsWE35JRhjP64fuN9irFF46edKo84uawPpqRQZ+g+cA1EDGrEyqgWQA6lUe H/4xkb7boXmwYIj//QjbozNF9rdXC8faSxLJzlR+SqxBEaw4ZqGAkEpNDUt/HMjJ 2+xcg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegvddgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 Aug 2022 10:03:18 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id CF985376; Wed, 10 Aug 2022 16:03:34 +0200 (CEST) Date: Wed, 10 Aug 2022 16:03:34 +0200 From: Alvaro Herrera To: Andres Freund Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Rely on __func__ being supported Message-ID: <20220810140334.itf5rw4mvfmojnuu@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220807174525.tbsrestw63ngblqf@awork3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello On 2022-Aug-07, Andres Freund wrote: > On 2022-08-07 19:40:14 +0200, Alvaro Herrera wrote: > > I'd rather we keep PG_FUNCNAME_MACRO defined to __func__ ... it costs us > > nothing. Would anybody oppose that? > > I'm fine with re-adding the macro, as long as we don't re-add in-tree users. After further thinking, I conclude there's no need for this. It's quite easy to add a "#ifndef PG_FUNCNAME_MACRO" stanza in third-party code if needed, and just rely on __func__ otherwise. Thanks -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/