Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMwVG-0001pS-Tq for pgsql-committers@arkaria.postgresql.org; Sat, 13 Aug 2022 19:08:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oMwVE-0004CY-1i for pgsql-committers@arkaria.postgresql.org; Sat, 13 Aug 2022 19:08:56 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMwVC-0004CP-Cx for pgsql-committers@lists.postgresql.org; Sat, 13 Aug 2022 19:08:55 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMwV4-0003rI-Si for pgsql-committers@postgresql.org; Sat, 13 Aug 2022 19:08:52 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 449DA5C00D3; Sat, 13 Aug 2022 15:08:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 13 Aug 2022 15:08:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1660417725; x=1660504125; bh=l4JmpQr1PF HfQZ6d7g1tc61VCoRWoOxALqGFYcX0ECY=; b=BkIU1tnTlvQYhzkEcNN9PYiPQg bGLjz84Dbkcg9PnrGhL82gcxlZ+/rFv86rQJyeTqt/NtWy7ozUQmKG1x7LntgLkL W/bEfAGQwEU9Xo4EDRfppmSAhl4Sl5FZuml1AYPdnNrTbsidv/HGLMqSVwJJPJLj jSZDaNiPoUD6zb6yr8AUa3fLB8NLY05M8QfV7kippdSBgbnWuzKC6K3zoHufKDD0 qJDac9byYFxyxWXq0hsSitPcGuR5ILPgQCAMkBgAFLOLs71Ps9QYYRgqJkiISvgB haBe8MNZiG3uBFeD/5Rc75GZgAqD9gIZTagpDjmcr4jeOKaXuodaQ2r8mYjg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660417725; x=1660504125; bh=l4JmpQr1PFHfQZ6d7g1tc61VCoRW oOxALqGFYcX0ECY=; b=bZ+wLnPFtbF2hk38fMZcKAYUDMP64z5DLS3whjh60ss4 cGhXgLVK5cGfglXYp1olcsMUFXZYxNVqYRJQaDuGwhodaSCChEvOeS/TFuIhzOzw oK71LMsRDLMOC6vdwD6mBdWMdY0O7c2/Cl/fuwfB/T1+W5+6nBzRDNrvXvsZMI1Z iJHFNcUt644zUp4qFs+N9CNBHPnqdbGSSL4AT9XboFXnHCBrQ63Qp0WnlXosNIGd acrK2zdQDHB7GdTZKhWDKhDE5zaATmcsTFIioO8qW2SKa0qPFFCMs9wzRnATOA2n wq19I+NpydI39PkMsyyBInjZue4L9yNJdPEmxXKFow== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegkedgudefiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgu rhgvshcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtf frrghtthgvrhhnpedvffefvefhteevffegieetfefhtddvffejvefhueetgeeludehteev udeitedtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 13 Aug 2022 15:08:44 -0400 (EDT) Date: Sat, 13 Aug 2022 12:08:43 -0700 From: Andres Freund To: Tom Lane Cc: Noah Misch , pgsql-committers@postgresql.org Subject: Re: [HACKERS] [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage. Message-ID: <20220813190843.wrs3feelaxy434un@awork3.anarazel.de> References: <307.1507819498@sss.pgh.pa.us> <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> <20171013023536.GA492146@rfd.leadboat.com> <12267.1507862660@sss.pgh.pa.us> <20171013070247.GA505228@rfd.leadboat.com> <21773.1507908395@sss.pgh.pa.us> <530.1507916887@sss.pgh.pa.us> <20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de> <1820.1507918762@sss.pgh.pa.us> <20171013182405.7smzzv3vw67o2fjy@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171013182405.7smzzv3vw67o2fjy@alap3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Noah, On 2017-10-13 11:24:05 -0700, Andres Freund wrote: > On 2017-10-13 14:19:22 -0400, Tom Lane wrote: > > > So it'd probably better to introduce a FORCE_DISABLE_RESTRICT=yes, set > > > at the same place, that's then tested before running the relevant > > > configure check? > > > > +1. I think you don't actually have to skip the configure check, > > and there might be some value in letting it carry on normally > > (so that "restrict" is set properly). We'd just want it to affect > > what pg_restrict gets defined as. Something like > > > if test "$ac_cv_c_restrict" = "no" -o "x$FORCE_DISABLE_RESTRICT" = "xyes"; then > > pg_restrict="" > > else > > pg_restrict="$ac_cv_c_restrict" > > Yea, that works. Will make it so. Any chance you could check if this is still needed? I've a FIXME about it in the meson code that I'd like to get rid of :) Greetings, Andres Freund