Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMy5L-0005md-IW for pgsql-committers@arkaria.postgresql.org; Sat, 13 Aug 2022 20:50:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oMy5K-0004FT-DH for pgsql-committers@arkaria.postgresql.org; Sat, 13 Aug 2022 20:50:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMy5J-0004DL-Ie for pgsql-committers@lists.postgresql.org; Sat, 13 Aug 2022 20:50:18 +0000 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oMy5G-0001fa-P2 for pgsql-committers@postgresql.org; Sat, 13 Aug 2022 20:50:17 +0000 Received: by mail-qk1-x734.google.com with SMTP id m5so3153849qkk.1 for ; Sat, 13 Aug 2022 13:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc; bh=rrQqOF14dMStOkr3QUTzYAP2iujvOvWE/aFuVYPNtXc=; b=C7ClRAtPx9zsydq+nmzMLQmVBWXgSWX7szvPHAbqFVJ7EalUoHBLYNmzAvRej3s5ug hNXxfkQ/zBUpgLaUfBISNy/nfRjefCf5Kyb+bvypbB/Il1f+WQEdb5TVgtesah5N/KNu uReA4Cirj0lFjJstFJQH6o9miI5xXaraqJJCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=rrQqOF14dMStOkr3QUTzYAP2iujvOvWE/aFuVYPNtXc=; b=s25NbU9tDEigz+k36BVtxy069o2PKNHYvYQOtGXrQaJT04UNdKddK00qLp/hdefF0I QmYPShYzL+uGYDJxghdNy1hoDJm73X0EPXSEIf7IOAYoPMXni7UILYrg7j8lMTDX9xkD CmUF3swgT98SGtha4mxoMl94frCKIpTTzKbfVkg7ik9mbazObnVI4lLqQwneRsqe7Tdf Tgjz9VJhLlrIMphTOse+1jhloJDCNvndkHhodC7tjuwUXh5tyiNXgHUV06eRRbem7AtX W6X4r1pxxbhrhsHHbJ151OGWR3LwUbyUTgqt3rKv2ZxuWtUPSygKkj065Szn+WCYMYDH Teog== X-Gm-Message-State: ACgBeo3vX8xkDFVhUmBaF5h6hnsCC1BFjIRAgQ9V+p/AhrRO1dUKpVT9 0wwvvVXKApqDryKHVBK/IU91Gw== X-Google-Smtp-Source: AA6agR5IvATKIj4eZ7JAoOVwIMEKhdMsYxPury3tSeUtxhe0xBQSg4LFCfqHd+Z04Wbv1UBTZoN1oQ== X-Received: by 2002:a05:620a:25c8:b0:6ae:bf82:8f36 with SMTP id y8-20020a05620a25c800b006aebf828f36mr7360630qko.354.1660423812995; Sat, 13 Aug 2022 13:50:12 -0700 (PDT) Received: from rfd.leadboat.com ([2600:1702:a20:5750::2e]) by smtp.gmail.com with ESMTPSA id t201-20020a37aad2000000b006b9264191b5sm5166909qke.32.2022.08.13.13.50.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Aug 2022 13:50:10 -0700 (PDT) Date: Sat, 13 Aug 2022 13:50:06 -0700 From: Noah Misch To: Andres Freund Cc: Tom Lane , pgsql-committers@postgresql.org Subject: Re: [HACKERS] [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage. Message-ID: <20220813205006.GC249116@rfd.leadboat.com> References: <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> <20171013023536.GA492146@rfd.leadboat.com> <12267.1507862660@sss.pgh.pa.us> <20171013070247.GA505228@rfd.leadboat.com> <21773.1507908395@sss.pgh.pa.us> <530.1507916887@sss.pgh.pa.us> <20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de> <1820.1507918762@sss.pgh.pa.us> <20171013182405.7smzzv3vw67o2fjy@alap3.anarazel.de> <20220813190843.wrs3feelaxy434un@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220813190843.wrs3feelaxy434un@awork3.anarazel.de> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Aug 13, 2022 at 12:08:43PM -0700, Andres Freund wrote: > On 2017-10-13 11:24:05 -0700, Andres Freund wrote: > > On 2017-10-13 14:19:22 -0400, Tom Lane wrote: > > > > So it'd probably better to introduce a FORCE_DISABLE_RESTRICT=yes, set > > > > at the same place, that's then tested before running the relevant > > > > configure check? > > > > > > +1. I think you don't actually have to skip the configure check, > > > and there might be some value in letting it carry on normally > > > (so that "restrict" is set properly). We'd just want it to affect > > > what pg_restrict gets defined as. Something like > > > > > if test "$ac_cv_c_restrict" = "no" -o "x$FORCE_DISABLE_RESTRICT" = "xyes"; then > > > pg_restrict="" > > > else > > > pg_restrict="$ac_cv_c_restrict" > > > > Yea, that works. Will make it so. > > Any chance you could check if this is still needed? I've a FIXME about it in > the meson code that I'd like to get rid of :) I ran hornet against 1c497fa72d, the commit that failed in https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hornet&dt=2017-10-12%2022%3A14%3A41. Similar failure today: "172 of 181 tests failed, 1 of these failures ignored."