Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRtuC-0006yQ-Sf for pgsql-committers@arkaria.postgresql.org; Sat, 27 Aug 2022 11:23:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oRtuB-0005NO-NN for pgsql-committers@arkaria.postgresql.org; Sat, 27 Aug 2022 11:23:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRtuB-0005NF-BS for pgsql-committers@lists.postgresql.org; Sat, 27 Aug 2022 11:23:11 +0000 Received: from mail-io1-xd29.google.com ([2607:f8b0:4864:20::d29]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oRtu7-0001NH-9z for pgsql-committers@lists.postgresql.org; Sat, 27 Aug 2022 11:23:10 +0000 Received: by mail-io1-xd29.google.com with SMTP id x64so3100916iof.1 for ; Sat, 27 Aug 2022 04:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:from:to:cc; bh=Escxg20Q+fLLkbnfU3rjWGeHxpqMh1uLXx7gNH0YGIs=; b=VCH97apjMxY4dbIjQMFO3eamvIYdKivAXQBdIyQ0pAMM67yZdds3tAvwpdsHGxsDwz viWHH+NkHI5p6VeLt/sSrDeyfE3neLxKee5VHXaHqgf02RvPdOEtPCx+jfeHiwl40KqU lWDa2XKdRCM5xPBXVmJqTxTQbf3mHnHshPOjo1SPbJKV0uTnAc6UfPsI9N8qnA0nMvqP nvF/3Ly6yzd9g/gaE8o5ZIdAdvTtBb5xHs2OyzyREq47NoUp8wtq3/FmNioOfjsGc2Ln 0sUavAiugH6T5ikJuy+8W18SPvlLuHAsJx2Gh9pIcozZNtq0dQI2rXr5XDl/l3XFjdZ5 QVUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc; bh=Escxg20Q+fLLkbnfU3rjWGeHxpqMh1uLXx7gNH0YGIs=; b=CO9bftgD2T3dGU2kuAsQbU3MoxKmbMKgGMPnU+pAwtYZ5NrTlGsS2u/eH2fJaEu/QK ZqqkqAChCRWyH9vxoDXnJ17XzGqWWAh5Zhs1OStPT+Z1wg9Q4y4lfgJyIMg+jl+UQBQv c0GmsW9LcJIarm6xMryDibwfu4BgmobTeMSLJvu9iXhRrEZDtdkG83gH0Wa1HY1Xu+sk USd3HFkRrg5iUAn6tCc8I5LL+2RP1vMuom6vPZZbXw+aY3pTTLMLxr+sZPhGFWp/gKvt n46A6WGGBIDTNxmYPhbfuzZihrJk5jyGPPT+nn/Tas7vvfCqohJnQsjXkjRwR5+unIol cnpg== X-Gm-Message-State: ACgBeo39mwonojJpQq2xTU8nEZSUIF1fz7lSR32p0BTEu0S7WDGNZTWs mFpfBuhKJjx7ZMFD6vARZCQ7rg== X-Google-Smtp-Source: AA6agR7f8jTaM+IfiH6gw5wKbzEa5Oj72rus5WywpB0C9eon+kf9wAoWGsSqfmuexlANvoDh3HjzVA== X-Received: by 2002:a05:6638:d10:b0:349:e318:f721 with SMTP id q16-20020a0566380d1000b00349e318f721mr6063364jaj.279.1661599386153; Sat, 27 Aug 2022 04:23:06 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id p5-20020a056638216500b00349fe349928sm1969658jak.157.2022.08.27.04.23.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Aug 2022 04:23:05 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id DB644800800; Sat, 27 Aug 2022 06:23:04 -0500 (CDT) Date: Sat, 27 Aug 2022 06:23:04 -0500 From: Justin Pryzby To: Peter Eisentraut Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Remove unnecessary casts in free() and pfree() Message-ID: <20220827112304.GL2342@telsasoft.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Aug 26, 2022 at 02:02:33PM +0000, Peter Eisentraut wrote: > Remove unnecessary casts in free() and pfree() This seems to be breaking cfbot's "warnings" test. [07:49:48.983] label.c:665:10: error: passing argument 1 of ‘pfree’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] [07:49:48.983] 665 | pfree(temp); I imagine it would've been reported earlier, except that this commit was within 60min of the commit that broke perl. -- Justin