Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oSqxh-00010f-Qo for pgsql-committers@arkaria.postgresql.org; Tue, 30 Aug 2022 02:26:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oSqxf-0006Xv-OY for pgsql-committers@arkaria.postgresql.org; Tue, 30 Aug 2022 02:26:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oSqxf-0006Xm-Hl for pgsql-committers@lists.postgresql.org; Tue, 30 Aug 2022 02:26:43 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oSqxd-0002gm-Gh for pgsql-committers@lists.postgresql.org; Tue, 30 Aug 2022 02:26:43 +0000 Received: by mail-pj1-x1029.google.com with SMTP id w88-20020a17090a6be100b001fbb0f0b013so10432679pjj.5 for ; Mon, 29 Aug 2022 19:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=yyW7YwF5NTWa2A20LwpgrPKEYvmW5a4Zu1Jb5tRYhhE=; b=bv9U5K8ChE2Qskumc57KQRCF3aQZQ/2Im0JLWv8i4KnQ3YUcTqRovJJ2E3WEXWF4RN 6r8vn1ArZcncrscklgQ+97ibaGpmMnL/2241ErbHQOAdci3JC2XuA1eEsafJIdqcj8O1 64aq9ivzmxPyoS8ihdgroJ0UQsTMTwdoX0Bgm8je+e8Xr2Zgu3GEyRi/S3lzBxv7ybmt X442WTBGDonOPRhtBVKnbZytem7tTWtolBAsdlaXMoZ8baA33AtAVTqt5LM1jhfbdhuD VjLHhNxRAPI6s/0bmj4Zah6ueZa1q5+40vPWC/4YKDRokyN8H7yakWTffiQRcKDFrH6F Uxeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=yyW7YwF5NTWa2A20LwpgrPKEYvmW5a4Zu1Jb5tRYhhE=; b=iL49L9jk90N876WLxA7LcJ+FAEXXIT5ln59gVq82/jem3WLJrss4xKmQIxENvwHJVy LElxprNIW4vT3FHlX0NPgN2kS7d1joegYXaCoXnb52XYoZ1Q6tVmKuRjjvTN+pCQ1Paa OMN5a51uMC9R/2pbQZu/ORt+tlXV+zrkp6oB5VBPA/YQVR66a/2E3/bcgTDiR4W+OuGi FxtvzqA4rlFWkTRpVkf39O6Z2lU890WLFI+jkmoOqFvtu8EV+PYDbCmtv6Q7rRu8usCU slDX1OKKAZaA2SplfS1T9ocW/31Q2omGHpNFhXQPkKgttsxLvGWa63Wu7XbMb/JggQHB m3yQ== X-Gm-Message-State: ACgBeo0v4agiNx5svDs8eFKYgzKPqn5pQaCx3ZGJ981Um4wiijMKST/F 890smQ571XQ4Fgh1eHOT+mCJo9692Z8= X-Google-Smtp-Source: AA6agR5kzczsA0JElAgWLmyVVtcsRt5f+Z4L5aqUURck7TDLyQKwZ4yEp1MtVBIb2gK+wXotSjwkVg== X-Received: by 2002:a17:90b:264e:b0:1fb:c093:36a2 with SMTP id pa14-20020a17090b264e00b001fbc09336a2mr21765161pjb.117.1661826399277; Mon, 29 Aug 2022 19:26:39 -0700 (PDT) Received: from jrouhaud (2001-b011-1006-9f07-51b8-d0a1-235d-3156.dynamic-ip6.hinet.net. [2001:b011:1006:9f07:51b8:d0a1:235d:3156]) by smtp.gmail.com with ESMTPSA id h21-20020a17090aa89500b001fd982478cbsm4808345pjq.45.2022.08.29.19.26.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 19:26:38 -0700 (PDT) Date: Tue, 30 Aug 2022 10:26:36 +0800 From: Julien Rouhaud To: John Naylor Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix broken cast on MSVC Message-ID: <20220830022636.qrcbcecmhztbxrwa@jrouhaud> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On Mon, Aug 29, 2022 at 10:45:43AM +0000, John Naylor wrote: > > +/* > + * Exactly like vector32_is_highbit_set except for the input type, so it > + * looks at each byte separately. > + * > + * [...] > + */ > +#ifndef USE_NO_SIMD > +static inline bool > +vector32_is_highbit_set(const Vector32 v) > [...] Shouldn't the comment be "Exactly like vector8_is_highbit_set..."? Also, is there any reason to not have a function prototype for this one? As far as I can see that's the only one that doesn't in simd.h.