Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUkSg-0000rE-Qi for pgsql-hackers@arkaria.postgresql.org; Sun, 04 Sep 2022 07:54:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oUkSf-0001sy-0l for pgsql-hackers@arkaria.postgresql.org; Sun, 04 Sep 2022 07:54:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUkSe-0001so-OO for pgsql-hackers@lists.postgresql.org; Sun, 04 Sep 2022 07:54:32 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUkSc-0006JU-0K for pgsql-hackers@lists.postgresql.org; Sun, 04 Sep 2022 07:54:32 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E372A5C0067; Sun, 4 Sep 2022 03:54:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 04 Sep 2022 03:54:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1662278068; x=1662364468; bh=q 0YYrB1vORRNP/nn5ONI3YjCubrQqCJuJBhhdoH4FzU=; b=vSItxEQQ/DUDQTon/ CsOKTgPE6MWE/i2pLRYivIPFs3B7NDjOuRr6esuNAOfK/kAhPr56DUGCMuVQRZaC TIdO9PySLgC0qun+QAzh2+2A2aPavFJHptuRd8jtsD7VXxWRvUEh6fC7pQJm5mjV ITUPG9/WKR2jIj+JNCSkLRLNJDkUK/qzy+Ar1r4vMi9hk69HfeSLPY7A1nzoQY3E nhy1ABpkMvY91dic2TQUfevubNnSqf/ThgWfwlsPA03I9fwQtWXaW+a/FF+HTA87 roqFxjJVr1+T3Fl+QPCqaou9VuxW7PaP2XyB2inr2yaIapUS0egazWiRo2bDV5vF PcIiw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdelfedguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhv rghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorh hgqeenucggtffrrghtthgvrhhnpedvkedtffduffdtffffheffhfejjefhgfeiueeukeej keffgfdufffhudffffeuveenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtoh hmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghl vhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 4 Sep 2022 03:54:28 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id DB03637D; Sun, 4 Sep 2022 09:54:50 +0200 (CEST) Date: Sun, 4 Sep 2022 09:54:50 +0200 From: Alvaro Herrera To: Thomas Munro Cc: pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Prefetch data referenced by the WAL, take II. Message-ID: <20220904075450.6g4nm4hralyw3tab@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Apr-07, Thomas Munro wrote: > Prefetch data referenced by the WAL, take II. I propose a small wording change in guc.c, diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 9fbbfb1be5..9803741708 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -2840,7 +2840,7 @@ static struct config_int ConfigureNamesInt[] = { {"wal_decode_buffer_size", PGC_POSTMASTER, WAL_RECOVERY, gettext_noop("Maximum buffer size for reading ahead in the WAL during recovery."), - gettext_noop("This controls the maximum distance we can read ahead in the WAL to prefetch referenced blocks."), + gettext_noop("This controls the maximum distance we can read ahead in the WAL to prefetch data blocks referenced therein."), GUC_UNIT_BYTE }, &wal_decode_buffer_size, "referenced blocks" seems otherwise a bit unclear to me. Other wording suggestions welcome. I first thought of "...to prefetch referenced data blocks", which is probably OK too. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual)