Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUwgj-0008MA-Po for pgsql-committers@arkaria.postgresql.org; Sun, 04 Sep 2022 20:57:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oUwgg-0007OK-8z for pgsql-committers@arkaria.postgresql.org; Sun, 04 Sep 2022 20:57:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUwgg-0007OB-1i for pgsql-committers@lists.postgresql.org; Sun, 04 Sep 2022 20:57:50 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUwge-0003zH-7W for pgsql-committers@lists.postgresql.org; Sun, 04 Sep 2022 20:57:49 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 660155C00B1; Sun, 4 Sep 2022 16:57:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 04 Sep 2022 16:57:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662325065; x=1662411465; bh=P0COrPSnr4 a2QdWUXsQfstw2FkGS6sdWVZpUDIcgqtc=; b=OF/xRULt6HLyBsjfptg4NpdQp5 6804QTm5rOrte20XIYvV/mblPTRqqSOag4ChFYh4Xu3Jl2TarL/eed8OxVA4d5WM w3+y7+tHRu6CIKk2yD0ek7smZxVl8e0bdOMy18DkmSANOCES9R129y/sWREnojl5 P80fRAVYmE0GN3Gr1NfxQ4TREpw6n3aGVLFkxO9fUnByG8Ib9tejGAjXR4e2cNXo fF9WR1SD7YqavXpBE7ylKXBIKliWcI8kiMijVEH6lTIBVpIC6t3RcPbNTpdeeVrU 3P79Xp4wcsvnkmOoHqKJsZfI7QgGulAuJ2PMi5gLUce4o/FxL4KWeXg/aAPw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1662325065; x=1662411465; bh=P0COrPSnr4a2QdWUXsQfstw2FkGS 6sdWVZpUDIcgqtc=; b=u++jxT4Xq1emeBZhSt8aRCfBs1aRbhCZqcryUyWS6LDY IjiWI0+M5FlgsZ6JvMHw/QyvkS63rM3kJ7eENJc6VlT6AMqaGcGoww/gLfLQFvBh sTH1ZcUgCy2Bt5s5IIPT1pRsyANiWtRukrl8YioTIsPDaah2Aqe6ZKjHNLNQdolt HDS9+9ovRXYd9ItLL8tFdy+LTdb1jI2LDU/KiRT9dGlR/DWtZdBZzChQRBqdiTwa jtsXY9Z2mNKENf9oOEdBY5DllaopkttOTuaObonENm3ICAzoHzB4OE4oISNVk9/m 5eFm1DtYF5Mb2D3o9j7zMTFGkI8o8PiUrcEl/4mXcw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdelgedgudehlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgu rhgvshcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtf frrghtthgvrhhnpefhgeejtddugeevffetfeejleejvdegteeulefftdffjeegffeggeeg ffetgeehueenucffohhmrghinheptghirhhruhhsqdgtihdrtghomhenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvshesrghnrghr rgiivghlrdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 4 Sep 2022 16:57:44 -0400 (EDT) Date: Sun, 4 Sep 2022 13:57:43 -0700 From: Andres Freund To: John Naylor Cc: John Naylor , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Build all Flex files standalone Message-ID: <20220904205743.y3ntq6ij3aibmxvy@awork3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-09-04 18:04:13 +0700, John Naylor wrote: > On Sun, Sep 4, 2022 at 4:36 PM John Naylor wrote: > > > > For this, Mkvcbuild.pm specifies specparse.c explicitly, so maybe > > something like the following is needed: > > > > --- a/src/tools/msvc/Mkvcbuild.pm > > +++ b/src/tools/msvc/Mkvcbuild.pm > > @@ -362,6 +362,7 @@ sub mkvcbuild > > $isolation_tester->AddFile('src/test/isolation/specparse.y'); > > $isolation_tester->AddFile('src/test/isolation/specscanner.l'); > > $isolation_tester->AddFile('src/test/isolation/specparse.c'); > > + $isolation_tester->AddFile('src/test/isolation/specscanner.c'); > > $isolation_tester->AddIncludeDir('src/test/isolation'); > > This gets CI green (tip o' the hat to Thomas Munro for off-list advice > on getting that working), so pushed. It doesn't seem to have gotten all of CI green, cpluspluscheck fails: https://cirrus-ci.com/task/6561938334285824 I think this just needs a copy the logic you added to headerscheck also to cpluspluscheck (and yes, we should merge these files one of these days). Greetings, Andres Freund