Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUwqp-0000bs-59 for pgsql-committers@arkaria.postgresql.org; Sun, 04 Sep 2022 21:08:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oUwqn-0008C5-Pj for pgsql-committers@arkaria.postgresql.org; Sun, 04 Sep 2022 21:08:17 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUwqn-0008Bw-I6 for pgsql-committers@lists.postgresql.org; Sun, 04 Sep 2022 21:08:17 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUwqk-0005FB-Re for pgsql-committers@lists.postgresql.org; Sun, 04 Sep 2022 21:08:16 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 36CE05C0043; Sun, 4 Sep 2022 17:08:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 04 Sep 2022 17:08:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662325694; x=1662412094; bh=hHCaGzK9ab rDUqyEK4o8VGE6rcyph0InSLgCVdJCPV0=; b=itcpgaq/Q8UU8tPQaLMc32Az8S OkugOfFMoi3NLyenzZi2bIfI930CsyskUb3hKlnNh0Iq02LV4FLIDvq1cfxq5e5c yhxRPo2VDDqF16gVXZQdZoW6oO4VP1VmsbOtq9JWVfjICNYGp+XDJY+mHJER0vb3 5JihTmx400MlLy3y0OKzUfqvM0aD7KX+4L5bJiryv4brcCNJ7Sr6e0SUhLPRHODS f0xUbpu2Br+kiowMEpkrixQ4ESapxZ8QqpS8wdYilqOEVPafpvOcRLab1/FZamXj OYrZj068orY3m7xYi8tfRQggigXFLJZTPqxZSVo0plwRnUJUpeqV2X1DZHYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1662325694; x=1662412094; bh=hHCaGzK9abrDUqyEK4o8VGE6rcyp h0InSLgCVdJCPV0=; b=DwLBPCrebRq3n1gcPtn2l8Zs7eFFTE14GizDE6TUCDx8 a2SmJTaFyU5WUtFt8MFewBZYD4Aj1VKE0Ls2XAze0MC08/N98I1htD+59pZfgf8Y Q/aUodimOxmcDpMer7rP4liKReCKuUcp/clyiGplfH+NQmgn8dM5IbiD1l1acgqC 8jjP3BeP4IobdL8DsA559ZUkNJJM4xI4ayaCcE7POi+S99rw1+k+J3oDmrkQZb11 FF9drpNQfX6USTcBTZGEcTidxaFqvO54Xm2h6T8WAaJd2j3RbY2hyFYnlu1M2AwW fZ+DvtmnHB8Twi57owBq9AsH0Niou1LJ/aGxyF0jwA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdelgedgudeivdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgu rhgvshcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtf frrghtthgvrhhnpeffudeuhfejlefhfffgleethfdutdevgeefteeihfdtudefheelkefg hfegleduueenucffohhmrghinhepphhgshhqlhdrsghuihhlugenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvshesrghnrghrrgii vghlrdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 4 Sep 2022 17:08:13 -0400 (EDT) Date: Sun, 4 Sep 2022 14:08:12 -0700 From: Andres Freund To: John Naylor Cc: John Naylor , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Build all Flex files standalone Message-ID: <20220904210812.icxugcz2syyts3ef@awork3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-09-04 13:19:56 +0700, John Naylor wrote: > Crake fails with > > headerscheck: > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2: > Sep 04 01:56:01 > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: > fatal error: jsonpath_gram.h: No such file or directory > Sep 04 01:56:01 26 | #include "jsonpath_gram.h" > Sep 04 01:56:01 | ^~~~~~~~~~~~~~~~~ > Sep 04 01:56:01 compilation terminated. > Sep 04 01:56:14 make: *** [GNUmakefile:138: headerscheck] Error 1 > cpluspluscheck: > Sep 04 01:57:19 In file included from /tmp/cpluspluscheck.HhRV5k/test.cpp:3: > Sep 04 01:57:19 > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: > fatal error: jsonpath_gram.h: No such file or directory > Sep 04 01:57:19 26 | #include "jsonpath_gram.h" > Sep 04 01:57:19 | ^~~~~~~~~~~~~~~~~ > > I don't get the same in an already-built tree. I also don't see an > exception for gramparse.h, which I imagine would have the same issue? It doesn't happen for gramparse.h because gram.h is copied to src/include/parser (see src/backend/Makefile), and included as parser/gram.h. I think this could be addressed by always adding something like -iquote $builddir/$(dirname "$f") -iquote $srcdir/$(dirname "$f") \ to cpluspluscheck/headerscheck. Greetings, Andres Freund