Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVrBz-0003fw-Fj for pgsql-committers@arkaria.postgresql.org; Wed, 07 Sep 2022 09:17:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrBy-0003Dy-3O for pgsql-committers@arkaria.postgresql.org; Wed, 07 Sep 2022 09:17:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVrBx-0003Dp-SH for pgsql-committers@lists.postgresql.org; Wed, 07 Sep 2022 09:17:53 +0000 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oVrBv-0001Rn-9H for pgsql-committers@lists.postgresql.org; Wed, 07 Sep 2022 09:17:52 +0000 Received: by mail-il1-x12b.google.com with SMTP id k2so7253483ilu.9 for ; Wed, 07 Sep 2022 02:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=VwnjMKfVwRa+LmWXYA0j2Jx5e0cMY/RsX4zoIG7l8DE=; b=kvJGmejvLYQsPmymwsb9I4cCvN7cVJTqY/scCwAhUMVz8Zafn4wUfpRpmFsuSAzI9x KaY3DHu3O2RvInMGlUVK2NnhWpAdrPm01KHPoo9KaleCD7Mq26XLONqA3KVPGtLyB3Bx sVqOxxll0QSLv3lpDkCP6/GHEewEjcOWfLz9HWNC9D8UXFP45BtZVAmguMzr6FTZ2aVd gmH4b0Wb6bskX44AiL5BeELZc7g9Gn3Oa6zFSLfFm1p0I+RtaSzGUjSmkHd7QUVGZ4eM yTv3lfxT9tWq0V/VWTLvurPiNkUnjhJZw2iP/bsiHhgyUJ2e+rWe1D1eXAUGOOL9VUT2 mLxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=VwnjMKfVwRa+LmWXYA0j2Jx5e0cMY/RsX4zoIG7l8DE=; b=QvHGAPiLDTpFP1+ADiI9DR6AtTkeg5oYLzYCdkrJra7nf+Oc7mxupSZygIKHrAZDTF UFxsw0QtowEnMgit3g2RVT0bHTl7YaFD9vyMN+FSKszW52kTlkBkBjhf0sSxGlwX9e88 nHA6fA4nX9ENgXjW4yRJ0/m4vEAB2+HfaEeVod3+7ePKJtq9vtUOMn0Jqa5MEAofhR3x kcXE48OlKZDgC1fBv98rLT4NnmF4qZNx8QZABGOff/4pkHXvmZMUaSPNCeML/OXRpMjS sssvSmssK4p/iCSqobO4gmWtsn6E1u/ah8qoTArtvd6RvBXPgw97jenrd2DEskmRt0gi effQ== X-Gm-Message-State: ACgBeo14cVDevUdaX0xgaQIhjn2hDJ25PaQKJajRhGe/Q8lFoFKbqZ/S fHJ2n6JO56+iu6KljDyjJdNuZw== X-Google-Smtp-Source: AA6agR6FQXhYMATHXRz3/M+aIC7aUfe448P8vigchRx2u2E0wuZFQJDyIZKzacNdbiHZgqchZqA48w== X-Received: by 2002:a05:6e02:20ce:b0:2eb:307d:a56c with SMTP id 14-20020a056e0220ce00b002eb307da56cmr1427669ilq.233.1662542270576; Wed, 07 Sep 2022 02:17:50 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id y8-20020a92c748000000b002dc2b20e9cfsm6204521ilp.1.2022.09.07.02.17.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Sep 2022 02:17:50 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 87E14800785; Wed, 7 Sep 2022 04:17:49 -0500 (CDT) Date: Wed, 7 Sep 2022 04:17:49 -0500 From: Justin Pryzby To: Peter Eisentraut Cc: pgsql-committers@lists.postgresql.org Subject: Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE Message-ID: <20220907091749.GY31833@telsasoft.com> References: <20220720145220.GJ12702@telsasoft.com> <5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com> <3052113.1662443873@sss.pgh.pa.us> <316575e0-64b8-3db6-865c-165b94958ce0@enterprisedb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <316575e0-64b8-3db6-865c-165b94958ce0@enterprisedb.com> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Sep 07, 2022 at 11:11:37AM +0200, Peter Eisentraut wrote: > On 06.09.22 08:27, Michael Paquier wrote: > > On Tue, Sep 06, 2022 at 01:57:53AM -0400, Tom Lane wrote: > > > Peter Eisentraut writes: > > > > I think renumbering this makes sense. We could just leave the comment > > > > as is if we don't come up with a better wording. > > > > > > +1, I see no need to change the comment. We just need to establish > > > the precedent that values within the GUC_UNIT_MEMORY field can be > > > chosen sequentially. > > > > +1. > > committed without the comment change Thank you