Feedback-ID: id4a34324:Fastmail
Date: Sun, 11 Sep 2022 11:19:25 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: aix: No need to use mkldexport when we want to export all
 symbol
Message-ID: <20220911181925.ygxbync3uk5ezcic@awork3.anarazel.de>
References: <E1oWpzF-002EG4-AG@gemulon.postgresql.org>
 <325593.1662783266@sss.pgh.pa.us>
 <89D645BA-FF97-4516-A21D-9FC4A4B31F8C@anarazel.de>
 <20220910043749.koidc5k4j5dxo3if@awork3.anarazel.de>
 <20220910052741.t7w7csyrggwus2ze@awork3.anarazel.de>
 <338810.1662787972@sss.pgh.pa.us>
 <20220910055736.htsr5juo3ldlay2l@awork3.anarazel.de>
 <20220910081944.oiayp5lky3kv2o43@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220910081944.oiayp5lky3kv2o43@awork3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/20220911181925.ygxbync3uk5ezcic%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-09-10 01:19:44 -0700, Andres Freund wrote:
> On 2022-09-09 22:57:36 -0700, Andres Freund wrote:
> > On 2022-09-10 01:32:52 -0400, Tom Lane wrote:
> > > Andres Freund <andres@anarazel.de> writes:
> > > > It seem worth applying the -qvisibility patch and seeing whether that fixes
> > > > the buildfarm?
> > >
> > > Worth a try.
> >
> > Done now.
>
> Seems to have done the trick for at least hoverfly. And wrasse (sunpro) is
> still happy. Still need to wait for the older xlc's (mandril, hornet)
> though...

At least hornet isn't happy:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hornet&dt=2022-09-10%2021%3A44%3A00

Looks like the support for -qvisibility came with xlc 13.1, released April 28, 2014:
https://www.ibm.com/common/ssi/cgi-bin/ssialias?subtype=ca&infotype=an&appname=iSource&supplier=897&letternum=ENUS214-162

> -qvisibility option specifies visibility attributes for entities. Entity
>  visibility attributes describe whether and how entities defined in one
>  module can be referenced or used in other modules. Visibility attributes
>  affect entities with external linkage only, and cannot increase the
>  visibility of other entities.


Since xlc 13.1 supports all still supported AIX versions I'm inclined to think
we should increase our requirement to 13.1 rather than revert back to the
higher complexity way of building modules.  We could also try to fall back to
using -Wl,b,expall for extension modules.

Greetings,

Andres Freund