Feedback-ID: id4a34324:Fastmail
Date: Tue, 13 Sep 2022 00:20:59 -0700
From: Andres Freund <andres@anarazel.de>
To: Noah Misch <noah@leadboat.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: aix: No need to use mkldexport when we want to export all
 symbol
Message-ID: <20220913072059.kqx7x4b47viza4te@awork3.anarazel.de>
References: <89D645BA-FF97-4516-A21D-9FC4A4B31F8C@anarazel.de>
 <20220910043749.koidc5k4j5dxo3if@awork3.anarazel.de>
 <20220910052741.t7w7csyrggwus2ze@awork3.anarazel.de>
 <338810.1662787972@sss.pgh.pa.us>
 <20220910055736.htsr5juo3ldlay2l@awork3.anarazel.de>
 <20220910081944.oiayp5lky3kv2o43@awork3.anarazel.de>
 <20220911181925.ygxbync3uk5ezcic@awork3.anarazel.de>
 <20220913033845.GA1439680@rfd.leadboat.com>
 <20220913061123.mxae5udw6ix2op7v@awork3.anarazel.de>
 <20220913070253.iwijs465fm354qtq@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220913070253.iwijs465fm354qtq@awork3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/20220913072059.kqx7x4b47viza4te%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-09-13 00:02:53 -0700, Andres Freund wrote:
> On 2022-09-12 23:11:23 -0700, Andres Freund wrote:
> > I'll check it out tomorrow. I configured perl on the other AIX gcc comp=
ile
> > farm machine building 64bit with both gcc and xlc, IIRC. I can't check =
rn,
> > they seem to be down?
>=20
> Seems to just have been a temporary connectivity issue.
>=20
> After battling a bit with bison flex (system m4 seems incompatible with s=
ystem
> flex?), solved by using your binaries, I suceeded building and testing pl=
perl
> on 346990ae2e
>=20
> ~/src/postgres/configure FLEX=3D/home/nm/bin/flex BISON=3D/home/nm/sw/bis=
on/bin/bison CXX=3D'g++ -maix64' CC=3D'gcc -maix64' PERL=3Dperl64 --cache .=
=2E/config-ac-gcc.cache --enable-cassert --enable-debug --with-perl
>=20
> gmake -j8 -s world-bin && gmake -j8 -s checkprep && gmake -j8 -s temp-ins=
tall
> cd src/pl/plperl/
> gmake check NO_TEMP_INSTALL=3D1
> ...
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>  All 13 tests passed.
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>=20
> "my" linking of plperl.so:
>=20
> gcc -maix64 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-afte=
r-statement -Werror=3Dvla -Wendif-labels -Wmissing-format-attribute -Wimpli=
cit-fallthrough=3D3 -Wcast-function-type -Wformat-security -fno-strict-alia=
sing -fwrapv -fexcess-precision=3Dstandard -Wno-format-truncation -Wno-stri=
ngop-truncation -g -O2  -fvisibility=3Dhidden -o plperl.so plperl.o SPI.o U=
til.o  -L../../../src/port -L../../../src/common    -Wl,-blibpath:'/usr/opt=
/perl5/lib64/5.28.1/aix-thread-multi-64all/CORE:/usr/lib:/lib:/opt/freeware=
/lib/gcc/powerpc-ibm-aix7.1.0.0/8.3.0/'  -Wl,-bnoentry -Wl,-H512 -Wl,-bM:SR=
E -shared -fvisibility=3Dhidden -L/usr/opt/perl5/lib64/5.28.1/aix-thread-mu=
lti-64all/CORE -lperl -lpthread -lbind -lnsl -ldl -lld -lm -lcrypt -lpthrea=
ds -lc -Wl,-bI:../../../src/backend/postgres.imp
>=20
> sungazer:
> wrap-gcc-8.3 -D_THREAD_SAFE=3D1 -D_LARGE_FILES=3D1 -maix64 -Wall -Wmissin=
g-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=3Dvla -W=
endif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3D3 -Wcast-f=
unction-type -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precis=
ion=3Dstandard -Wno-format-truncation -Wno-stringop-truncation -g -O2  -fvi=
sibility=3Dhidden -o plperl.so plperl.o SPI.o Util.o  -L../../../src/port -=
L../../../src/common   -L/home/nm/sw/nopath/libxml2-64/lib -L/home/nm/sw/no=
path/icu58.2-64/lib  -L/home/nm/sw/nopath/uuid-64/lib -L/home/nm/sw/nopath/=
openldap-64/lib -L/home/nm/sw/nopath/icu58.2-64/lib -L/home/nm/sw/nopath/li=
bxml2-64/lib -Wl,-blibpath:'/usr/opt/perl5/lib64/5.28.1/aix-thread-multi-64=
all/CORE:/home/nm/sw/nopath/libxml2-64/lib:/home/nm/sw/nopath/icu58.2-64/li=
b:/home/nm/sw/nopath/uuid-64/lib:/home/nm/sw/nopath/openldap-64/lib:/home/n=
m/sw/nopath/icu58.2-64/lib:/home/nm/sw/nopath/libxml2-64/lib:/usr/lib:/lib:=
/opt/freeware/lib/gcc/powerpc-ibm-aix7.1.0.0/8.3.0/'  -Wl,-bnoentry -Wl,-H5=
12 -Wl,-bM:SRE -shared -fvisibility=3Dhidden -Wl,-bE:/usr/opt/perl5/lib64/5=
=2E28.1/aix-thread-multi-64all/CORE/perl.exp -Wl,-bE:/usr/opt/perl5/lib64/5=
=2E28.1/aix-thread-multi-64all/CORE/perl.exp -Wl,-brtl -Wl,-bdynamic -Wl,-b=
64  -L/usr/opt/perl5/lib64/5.28.1/aix-thread-multi-64all/CORE -lperl -lpthr=
ead -lbind -lnsl -ldl -lld -lm -lcrypt -lpthreads -lc -Wl,-bI:../../../src/=
backend/postgres.imp
>=20
> I suspect the problem is the -Wl,-bE:/.../perl.exp - that'll obviously
> restrict the exports of plperl.so to the ones of perl, which obviously is
> wrong.  I would have assumed that Peter's recent plperl changes should ha=
ve
> gotten rid of the -Wl,-bE:?

The spurious -Wl,-bE's are the cause of all these warnings btw:

ld: 0711-415 WARNING: Symbol ASCII_TO_NEED is already exported.
ld: 0711-415 WARNING: Symbol boot_DynaLoader is already exported.
ld: 0711-415 WARNING: Symbol NATIVE_TO_NEED is already exported.
ld: 0711-415 WARNING: Symbol Perl__add_range_to_invlist is already exported.
ld: 0711-415 WARNING: Symbol Perl__core_swash_init is already exported.
[~1150 more]
ld: 0711-415 WARNING: Symbol PL_Yes is already exported.
ld: 0711-415 WARNING: Symbol PL_Zero is already exported.

Greetings,

Andres Freund