Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY2qV-0006T8-Tm for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Sep 2022 10:08:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oY2pW-0003hD-Ry for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Sep 2022 10:07:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY2pW-0003g8-HY for pgsql-hackers@lists.postgresql.org; Tue, 13 Sep 2022 10:07:46 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY2pU-0002LV-5l for pgsql-hackers@lists.postgresql.org; Tue, 13 Sep 2022 10:07:45 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id ACE545C0192; Tue, 13 Sep 2022 06:07:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 13 Sep 2022 06:07:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1663063662; x=1663150062; bh=e ys8ttjgMtYjBv1VTJZiNfX9JUXOEusSRGlYaw1aKzQ=; b=Ncf/3VX4WiMOyQZsD PFkvQRyeLM97rwtVJka7r1Gu4OjoOF5qRh7vQB1zbjWUdJSHV76/9sP0fVeKKm8d Z5S/LGbUEx18J1NdDkwf3cnA/6e0ewJOl5ML3fMxGL4ogIMWGaF7dm+42gb8UUdh RXHGEIfSLqnnG5cLHIP9yngzTaPQQc2sLNMfO+E8mT/QxPK9Ldg6POCPQzXHzmVf A2Fr4vhWMdqXifrd085xo1h0Q7Qq6LgCD0LNsaI6fM8R3bKM/5A5kipFexFfQhzx EeNIQOCBXJxE6hb9EPMi+nmRZG2GaWx7VeREffBcNkL5u/wkBGvX5N2z6bhdIKjt LpnFQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedugedgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Sep 2022 06:07:42 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 9C9EA38C; Tue, 13 Sep 2022 12:07:40 +0200 (CEST) Date: Tue, 13 Sep 2022 12:07:40 +0200 From: Alvaro Herrera To: Thomas Munro Cc: Thomas Munro , PostgreSQL Hackers Subject: Re: pgsql: Prefetch data referenced by the WAL, take II. Message-ID: <20220913100740.cgt3cddnrjt3syuu@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Sep-13, Thomas Munro wrote: > I'd go for your second suggestion. 'therein' doesn't convey much (we > already said 'in the WAL', and therein is just a slightly formal and > somehow more Germanic way of saying 'in it' which is kinda > duplicative; maybe 'by it' is what we want but that's still kinda > implied already), whereas adding 'data' makes it slightly clearer that > it's blocks from relations and not, say, the WAL itself. > > Also, hmm, it's not really the 'Maximum buffer size', it's the 'Buffer size'. Sounds reasonable. Pushed these changes. Thank you! -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez)