Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYAbM-0003tf-Sk for pgsql-committers@arkaria.postgresql.org; Tue, 13 Sep 2022 18:25:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oYAbL-000221-Oy for pgsql-committers@arkaria.postgresql.org; Tue, 13 Sep 2022 18:25:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYAbK-00021s-OE for pgsql-committers@lists.postgresql.org; Tue, 13 Sep 2022 18:25:39 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYAbF-000668-R9 for pgsql-committers@lists.postgresql.org; Tue, 13 Sep 2022 18:25:38 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id ADA325C0222; Tue, 13 Sep 2022 14:25:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 13 Sep 2022 14:25:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663093532; x=1663179932; bh=an6YGJcgoV nYhCmZ2lRfUu+6sVRXG4bgUatAFHm/thw=; b=vfVpX6pTh1orI8ZubgdnAApJhY zzcI6e+Gj5knW4OwOUQG1r6/YZI65vCWpxZL8zNtlWHoi1RLZPd3hBx0+ZhTgj9D Ro0Ducguq3wFI3YOEvlTOCDv3GzQSC0r1R5CksBVHxA8wfHLTVNEKApyURugh9pk dqHQr+hS2w3XFkMdYNvQ+ZCoKQq/qTVVWQAnpqsmQc9j0LlJ4vMoLEw5HD1jSTSi DTcZeEFjit+FH5pZpHrtXFkg+fofrETtBdPrYJhMPX6rC5YMdmGDY7ZxHFHS0Rvj /0N3tlJ4ruVI5T4JiJRziQzYHCfF1gpHUToqVNIaG3jFKPqk82Z9kwb/a45w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663093532; x=1663179932; bh=an6YGJcgoVnYhCmZ2lRfUu+6sVRX G4bgUatAFHm/thw=; b=jE9pi1wC7VHwlORQj7QCjpgaQnaPBqxadE5NISxypNZk 6D0qJSbKCCYnTiQ8ldL5SRWnDy0bB6HQ8aETLvhfXV3jwwF7Rcy3WTqKh2pKPGKE Rs/Z+mXYJaPwO+9UGySle8L55VQ1pE9e6TCPaOEOYK6qzjVi0qb/LWIron8cvOPx rm+o6ISb2hXY/SQjhzb0srP9z9qDSljV1KjNz5ilGLTnSRSF13rnRZNw8584ya5/ x/WWWKQfMW/btAFpKKfty7FphaUjZINIW48Yr0IeJpKExXNzNkag4fpoS3rJheH+ L2wADjzNJg1LEKht2QMlIY5cZQHles7CmumTCfUqbg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedugedguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehmtderredttddvnecuhfhrohhmpeetnhgu rhgvshcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtf frrghtthgvrhhnpeekieeugeevudeguedtieefffeivdfgueegkefhfedtveefkefflefg geevhfdujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Sep 2022 14:25:31 -0400 (EDT) Date: Tue, 13 Sep 2022 11:25:30 -0700 From: Andres Freund To: Tom Lane Cc: Noah Misch , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: aix: No need to use mkldexport when we want to export all symbol Message-ID: <20220913182530.4yq35ralujjsv2k3@awork3.anarazel.de> References: <325593.1662783266@sss.pgh.pa.us> <89D645BA-FF97-4516-A21D-9FC4A4B31F8C@anarazel.de> <20220910043749.koidc5k4j5dxo3if@awork3.anarazel.de> <20220910052741.t7w7csyrggwus2ze@awork3.anarazel.de> <338810.1662787972@sss.pgh.pa.us> <20220910055736.htsr5juo3ldlay2l@awork3.anarazel.de> <20220910081944.oiayp5lky3kv2o43@awork3.anarazel.de> <20220911181925.ygxbync3uk5ezcic@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="mndcuvvpfuiopqcv" Content-Disposition: inline In-Reply-To: <20220911181925.ygxbync3uk5ezcic@awork3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --mndcuvvpfuiopqcv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On 2022-09-11 11:19:25 -0700, Andres Freund wrote: > We could also try to fall back to using -Wl,b,expall for extension modules. expall doesn't work, because of our use of identifiers in reserved namespaces, e.g. _PG_init: expall Exports all global symbols, except imported symbols, unreferenced symbols defined in archive members, and symbols beginning with an underscore (_). You can export additional symbols by listing them in an export file or using the expfull option. This option does not affect symbols exported by the autoexp option. However, there also is 'expfull' - IIRC that causes problems when used for postgres, but appears to be fine for .so's. So we could work around the xlc 12.1 issue with something like the attached patch. It passes at some of the tests, with both 32 and 64bit xlc 12.1, will have to wait a while to see more I think it'd be considerably better to just not support xlc < 13.1 though. This won't fix sungazer, that just needs the perl wrapper removed... Greetings, Andres Freund --mndcuvvpfuiopqcv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-wip.patch"