Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYuml-0000ID-4v for pgsql-committers@arkaria.postgresql.org; Thu, 15 Sep 2022 19:44:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oYumj-0007ae-Qm for pgsql-committers@arkaria.postgresql.org; Thu, 15 Sep 2022 19:44:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYumj-0007aV-K2 for pgsql-committers@lists.postgresql.org; Thu, 15 Sep 2022 19:44:29 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYumh-0006xJ-Jo for pgsql-committers@lists.postgresql.org; Thu, 15 Sep 2022 19:44:29 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 6AC4B32009AF; Thu, 15 Sep 2022 15:44:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 15 Sep 2022 15:44:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663271063; x=1663357463; bh=idSf0zirH6 oLCtFfKgv649W8PU3Sx8coOg/z8Qx04I4=; b=WMIRpeu19iqZctxkKdtBI5nup4 Je7ImLQRC9mHyeMNkXxy8M80Eo7v2WoKF5DtrPKk516iJpKk04hYWRv1hjRtyhVY bChRc+obS03BGIPIBPRqMO6yhgZNvvbExfvxhRJup7aWLtc/UTevK4bK1hl6KqzI 33aJsqVDDYemf79PzAmn0WfIJpaqojV/QQBTmTMorgY3gau1GiXtlH33qvBUPd3E eDosNDAJjHXCRvnKzW7F62Qjtm1IdyeKSucCXYFnti8xUigEcAz2N1ELOKi2Q60Y 6r3aPiP0xHNsEPU5fiuF+SNSliK5V3KQnTQafFad84PryHDbqHYTAn3Xof9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663271063; x=1663357463; bh=idSf0zirH6oLCtFfKgv649W8PU3S x8coOg/z8Qx04I4=; b=ujdOMmUsFluvLpcBo9DD8lgTvkVlbqXTj50j5GAR2bAb AD4iYu6Jz8j7KRi/pA37FlOmyoEA/NrHKVBikvvICAQ5d5NliOdVC1vZ4/8qO2oE 8UPJncSbDrceuV0IeP6b5JAM/teDowW2RwgTn6FHodK3seskIDH0w+xHVB5Avz3n sBL0AyKCsLLv//xxs5j6E+97Vz2Qsyh5eOQ4nFDPczn22UKnaB2WN6QFyNgJ/NAj ShQHL7QdOY726Mffp3hA3iR3iIEgsG3RHu5vuq0d5CqkNJNdrFMe/LlKgJ5BP2ks ybFyHk2vzykmk2y7BYqb3D0uIA+5DjUpO/FzhOQrpw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedukedgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgu rhgvshcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtf frrghtthgvrhhnpedvffefvefhteevffegieetfefhtddvffejvefhueetgeeludehteev udeitedtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Sep 2022 15:44:23 -0400 (EDT) Date: Thu, 15 Sep 2022 12:44:22 -0700 From: Andres Freund To: Tom Lane Cc: Noah Misch , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: aix: No need to use mkldexport when we want to export all symbol Message-ID: <20220915194422.bbdzwo7gmcvwzv4b@awork3.anarazel.de> References: <325593.1662783266@sss.pgh.pa.us> <89D645BA-FF97-4516-A21D-9FC4A4B31F8C@anarazel.de> <20220910043749.koidc5k4j5dxo3if@awork3.anarazel.de> <20220910052741.t7w7csyrggwus2ze@awork3.anarazel.de> <338810.1662787972@sss.pgh.pa.us> <20220910055736.htsr5juo3ldlay2l@awork3.anarazel.de> <20220910081944.oiayp5lky3kv2o43@awork3.anarazel.de> <20220911181925.ygxbync3uk5ezcic@awork3.anarazel.de> <20220913182530.4yq35ralujjsv2k3@awork3.anarazel.de> <2490844.1663123546@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2490844.1663123546@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-09-13 22:45:46 -0400, Tom Lane wrote: > Andres Freund writes: > > So we could work around the xlc 12.1 issue with something like the attached > > patch. It passes at some of the tests, with both 32 and 64bit xlc 12.1, will > > have to wait a while to see more > > Shouldn't that be more like > > + if test "$pgac_cv_prog_CC_cflags__qvisibility_hidden" != "yes"; then > + CFLAGS_SL_MODULE='$CFLAGS_SL_MODULE -Wl,-b,expfull' > + fi > > to avoid losing whatever we found out before that? Yes, you're right. There's nothing today, but we shouldn't assume that. > > I think it'd be considerably better to just not support xlc < 13.1 though. > > A three-line patch doesn't seem like an unreasonable thing to carry, > at least till these systems go out of support. We've jumped through > much higher hoops in the past to support niche platforms. xlc 12.1 *is* out of support and there's a newer compiler installed. The amount of lines itself doesn't bother me. What does is that it makes an already complicated platform more complicated: All symbols from extension .so's are exported, but only for old and unsupported versions of the proprietary compiler. Greetings, Andres Freund