Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZGFA-0007vR-Ts for pgsql-committers@arkaria.postgresql.org; Fri, 16 Sep 2022 18:39:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oZGF9-00008F-MA for pgsql-committers@arkaria.postgresql.org; Fri, 16 Sep 2022 18:39:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZGF8-000083-5u for pgsql-committers@lists.postgresql.org; Fri, 16 Sep 2022 18:39:15 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZGF3-0004Xu-Fb for pgsql-committers@lists.postgresql.org; Fri, 16 Sep 2022 18:39:13 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D5EF65C01FA; Fri, 16 Sep 2022 14:39:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 16 Sep 2022 14:39:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663353545; x=1663439945; bh=6E9K8lwqIs dYSgjlQz+N+paykeDZbhfIAI7uRV/iNhg=; b=Z/LiTA6vuMfncj7Ki4eMcclurm +FKPALp3a37Bn/PJ4fitPjjSaNr3Fau3ohX4aC9WjCi/j6b5tWv/Qh6WOm+21A6U jb1jYcy1yoeHCNLeBjvkkqic5uaXRr0dCbRCWpWyu7KBcinnjOvyQaJQLOnOZ+vX q+IhTMV08+1HhIvjc/KNAu5kSHiiL+fbRA0JboeyyVcl46ROfgX+hMsYssKZ/62p Ier/GobGfyETWOTZypTTVFdnb3EBYDkJEY9GYLeEZDulK6mnZP0GUaRJojIl77t6 tyLv+at9alPqWDPt+dcyu7NJD6nA30i+hpyHpRQl6UYOYmJ5RZ3Qvlmd/Agw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663353545; x=1663439945; bh=6E9K8lwqIsdYSgjlQz+N+paykeDZ bhfIAI7uRV/iNhg=; b=VwtIxrY068929D4+j8X88PBVB2BkCm1Wkv2fDNGqdhxn ChzQuBXkodsm+usN7LY1SSNkXhKzetkiXcEE513nAF7EeC/4YKIpXXrHyNKxiyDR xoJydeRS11vQAplhCiMv/NGWU8XJnefeR+4vrY4A2YI5KYmxLWaT9graUepY3fvk aCyS3kHzL6DA3h3Hs4ASVvXWAa8ePq9BYbI/NZ2OyJpgtxZglssZ7e0zvzC3tyZH t9a92St/f8r6G05OpR56Q87NG36AyLvNyWotkFDI0M9pUtgMPdagJBS3ObakvRWU m+xM/dzZffks64D3rIVQmj7IDYUZ4jlnl+IGMOBY6g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvtddgudeftdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkfhggtggujgesth dtredttddtvdenucfhrhhomheptehnughrvghsucfhrhgvuhhnugcuoegrnhgurhgvshes rghnrghrrgiivghlrdguvgeqnecuggftrfgrthhtvghrnhepffduuefhjeelhfffgfelte fhuddtveegfeetiefhtddufeehleekgffhgeeludeunecuffhomhgrihhnpehpghhsqhhl rdgsuhhilhgunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homheprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 14:39:05 -0400 (EDT) Date: Fri, 16 Sep 2022 11:39:04 -0700 From: Andres Freund To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: pgstat: add/extend tests for resetting various kinds of stats. Message-ID: <20220916183904.sss3vsau5tfgtx56@awork3.anarazel.de> References: <3428246.1663271992@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3428246.1663271992@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-09-15 15:59:52 -0400, Tom Lane wrote: > Andres Freund writes: > > pgstat: add/extend tests for resetting various kinds of stats. > > crake just failed [1] with what appears to be a race condition in > a test case added by this commit: > > diff -U3 /home/andrew/bf/root/HEAD/pgsql/src/test/regress/expected/stats.out /home/andrew/bf/root/HEAD/pgsql.build/src/test/recovery/tmp_check/results/stats.out > --- /home/andrew/bf/root/HEAD/pgsql/src/test/regress/expected/stats.out 2022-07-18 13:32:25.155847949 -0400 > +++ /home/andrew/bf/root/HEAD/pgsql.build/src/test/recovery/tmp_check/results/stats.out 2022-09-15 12:44:10.022975164 -0400 > @@ -563,7 +563,7 @@ > SELECT sessions > :db_stat_sessions FROM pg_stat_database WHERE datname = (SELECT current_database()); > ?column? > ---------- > - t > + f > (1 row) > > -- Test pg_stat_bgwriter checkpointer-related stats, together with pg_stat_wal > > It seems likely to me that the n_sessions increment hasn't made it to shared > memory because some background process happened to have a lock on the stats > entry when we tried. Don't we need a pg_stat_force_next_flush() call before > trying to inspect the sessions count? Indeed. Pushed a fix. To see if there are other omissions, I made pgstat_report_stat() never flush stats unless force is passed in. No other failures. > BTW, the header comment for pgstat_report_stat is badly in need of > copy-editing. Hm - you're talking about this sentence? ... Callers can use the returned time to set up * a timeout after which to call pgstat_report_stat(true), but are not * required to to do so. Reads awkward. I'm struggling with the english language trying to improve it :(. "Callers can, but are not required to, use the returned time to set up a timer, whose expiration should trigger a call to pgstat_report_stat(true)."? Greetings, Andres Freund