Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaRpI-0005x1-07 for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Sep 2022 01:13:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oaRpG-0002B2-S8 for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Sep 2022 01:13:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaRpF-0002At-Ru for pgsql-hackers@lists.postgresql.org; Tue, 20 Sep 2022 01:13:26 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaRpA-0001I0-MG for pgsql-hackers@lists.postgresql.org; Tue, 20 Sep 2022 01:13:24 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A59AA5C047E; Mon, 19 Sep 2022 21:13:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 19 Sep 2022 21:13:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663636399; x=1663722799; bh=DAWs5+z3L1 0wgU8ZSZMZaDCLf0NrplkPIXp2qzaZ2AA=; b=H1y4HEehVNKLWGmdU92i/QP9iW 0aCj6B6PHvOnVKGz/eHGUJoCo1I8oxHt8SYs3643niSPpvVL9a/lqTk/1n2jUgMs k/EbRKX0v44C7PQ+U/KKJVEyITv9EcsGSLB5IAD0YnfKSES/Ej8v/5NPxMw2vyqB uEICahP+Xs4grQ0jwshS8WOGyYX9+VbUb657SgasIMCoMaxnh+EEZKiZ701rudn8 Hwz25khoRNRsY4SD9vuYIJrDhGa4lEBdWEnT+wA6T1RGGZA+01yRBAxvoo3DYq+z nDPjIdQc20fdg9YyoC2UEDwSTl0VUeKHy4sgbU6cQW/GO6gxFVQM/OJbOdAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663636399; x=1663722799; bh=DAWs5+z3L10wgU8ZSZMZaDCLf0Nr plkPIXp2qzaZ2AA=; b=fNf2SdCM0+kyDrmlEKG5LF3seQlYn50KAgOLzPlyQD5Q K5ET63WRoIMs8ccmCP6HR6ZAjPiIAUlKK+231on1N9YXkw2LCZcc/0KlVSq4dYmb 3g1FDEnKmYosrtsRXekbOS7D4IenxCmMVEBzCCfl6tpx1fgaG3xAHl/yRYNnMUZo x3hlv+6kKovgJw5RQiyDOsL3kRh5G+5hiXVwbxEpyeatss/9eNTLjzwK7JQjkSLk 3xW9uWU35eziASSLi0hTBgpju/7hSn+BGRV8eVIXQ8zwhu6cytWbHQkg+UhldlSJ JCmTsoPvkbWquKyAWSyCNpHRhWgd1kGvphwohm2SQQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvkedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepvdfffeevhfetveffgeeiteefhfdtvdffjeevhfeuteegleduheetvedu ieettddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Sep 2022 21:13:19 -0400 (EDT) Date: Mon, 19 Sep 2022 18:13:17 -0700 From: Andres Freund To: Michael Paquier Cc: pgsql-hackers@lists.postgresql.org Subject: Re: pg_upgrade test failure Message-ID: <20220920011317.24bbsihqwn5dg7fi@awork3.anarazel.de> References: <20220919213217.ptqfdlcc5idk5xup@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-09-20 10:08:41 +0900, Michael Paquier wrote: > On Mon, Sep 19, 2022 at 02:32:17PM -0700, Andres Freund wrote: > > I don't know if actually related to the commit below, but there've been a > > lot of runs of the pg_upgrade tests in the meson branch, and this is the first > > failure of this kind. Unfortunately the error seems to be transient - > > rerunning the tests succeeded. > > This smells to me like a race condition in pg_upgrade (or even pg_ctl > for SERVER_LOG_FILE) where the code still has handles on some of the > files in the log/ subdirectory, causing its removal to not be able to > finish happen. I don't really see what'd race with what here? pg_upgrade has precise control over what's happening here, no? > If this proves to be rather easy to reproduce, giving > a list of the files still present in this path would give a hint easy > to follow. Does this reproduce with a good frequency? I've only seen it once so far, but there haven't been many CI runs of the meson branch since rebasing ontop of the last changes to pg_upgrade. Greetings, Andres Freund