Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odFg6-00008o-6k for pgsql-committers@arkaria.postgresql.org; Tue, 27 Sep 2022 18:51:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1odFg4-0006xy-4s for pgsql-committers@arkaria.postgresql.org; Tue, 27 Sep 2022 18:51:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odFg3-0006wA-PD for pgsql-committers@lists.postgresql.org; Tue, 27 Sep 2022 18:51:31 +0000 Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1odFfw-0008Cr-Ul for pgsql-committers@lists.postgresql.org; Tue, 27 Sep 2022 18:51:31 +0000 Received: by mail-io1-xd34.google.com with SMTP id h194so8483929iof.4 for ; Tue, 27 Sep 2022 11:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=qTskKn+PWN6Ob7fZm9iavIIGyPXL7gNm2uGG0gxtLwQ=; b=WF3UGj7U/Qc9WlIZ1Lui03oKPFPu+aEDXJ7CUDugWR8PUpzabvHgpblBTr7DQHZ9yl YurGxUEJwnQrCUuQnrExa+V+gwmEFgctI7qgBlxh+iexLua6OVRnd59K5f+/Lk4Tmg4C GGkYpffNHQEllfzbukSZGgWKf/KcJY1kPly9AVfLpGuNkzE+lVNJBX5VBqxL3p+iY9fU m9IWpB1TOttkxyD0mWT5fc7e4u6ZVmcQqiXQ5I4/i9gWq9wB/Fr2DW1f3CDjFRTiJ7AJ ww6dUt8wzw3zwBU41dav9s26dmZeZQ9PTKhww0jLko2hdyZLgmdDpXoUwA1lwwjTtNRj B8xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=qTskKn+PWN6Ob7fZm9iavIIGyPXL7gNm2uGG0gxtLwQ=; b=LHDKFTD10xPwLsCVt0ra47q+Kg5/ZpG3V5Sb3M7PPxobcruXW7S6CgmDv0pVHMillz tPrRtXG8/VuhhFzZ0d5FRWJW50usOBADKGUASQnmuAMcFxVMWv+XHCt7znoop1YCTVDw YPMVdmHCLPQbiDjBzSDQXxzWv3SRFEdsgN+LkyHEyheYcg184vBvG0TVacr7QYYcPaUq F2HpewiBEK6JN9bu6a4plA64PZ6bjEKWcBiUk32RSsy2u9u6PbRHf4h1unJGiCvWLf4y z2xC1BLly4j4n2BBOkzCO625sp7DxbWxHnbLKxP/wjPprOvs06OI6LRDDoojIS+1N5u8 h34g== X-Gm-Message-State: ACrzQf2A8x9Giz03wflrtdw1Mi4pxBm2aH92sK2WBCCMkX5OIUl9Nv6R OIzrSlDCyvyBVAxLgZsDp8d/6RmdoeNrlQ== X-Google-Smtp-Source: AMsMyM7bTiy5WRGrsIuXI15HYpf+GblZnSzVJvkh1koRJhXlTHDvD+C20SATXZi2vTf2RBhDZ4ASTA== X-Received: by 2002:a05:6602:29c7:b0:68b:3a08:4512 with SMTP id z7-20020a05660229c700b0068b3a084512mr12919841ioq.199.1664304683058; Tue, 27 Sep 2022 11:51:23 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id z19-20020a027a53000000b0035a468b7fbesm884112jad.71.2022.09.27.11.51.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Sep 2022 11:51:22 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 7D98880412D; Tue, 27 Sep 2022 13:51:21 -0500 (CDT) Date: Tue, 27 Sep 2022 13:51:21 -0500 From: Justin Pryzby To: Robert Haas Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Increase width of RelFileNumbers from 32 bits to 56 bits. Message-ID: <20220927185121.GE6256@telsasoft.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This seems to be breaking cfbot: https://cirrus-ci.com/github/postgresql-cfbot/postgresql For example: https://cirrus-ci.com/task/6720256776339456 Some other minor issues: thais is only used during => this + elog(ERROR, "unexpected relnumber " UINT64_FORMAT "that is bigger than nextRelFileNumber " UINT64_FORMAT, => there should be a space before "that". + "tli %u; prev tli %u; fpw %s; xid %u:%u; relfilenumber " UINT64_FORMAT ";oid %u; " => and a space before "oid" + * Parse relfilenumber value for an option. If the parsing is successful, + * returns; if parsing fails, returns false. returns *true;