Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onRVl-00072f-NW for pgsql-committers@arkaria.postgresql.org; Tue, 25 Oct 2022 21:31:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1onRVk-0007UZ-2v for pgsql-committers@arkaria.postgresql.org; Tue, 25 Oct 2022 21:31:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onRVj-0007UP-NZ for pgsql-committers@lists.postgresql.org; Tue, 25 Oct 2022 21:30:59 +0000 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1onRVh-0000RK-Cx for pgsql-committers@lists.postgresql.org; Tue, 25 Oct 2022 21:30:58 +0000 Received: by mail-il1-x12b.google.com with SMTP id i9so7663275ilv.9 for ; Tue, 25 Oct 2022 14:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=CsI29o49v7OzZiQnFoYh6md8pmnPwsYgrec/MYxjVew=; b=04NxWvnzTWIkJvs5Q72PbqZ0ejRbVwysKH7dM67Hi7vMbpU2BLouPKMEqd4CC5hdS9 /VFTo6tAq+jogkZKvT0jfiHkF4afWBB35BktoWDCpZPEmcENX04Nm2w90XzDSoq3dItN uQU0qjiq/j4KHMZytSkPdfFbQCdVsC+Yr3VGcADHhI7+XMm+4Yu8clMJvAFJKobdlsmB 78WOjO03S3m4elsGZLhRNxGSjkQj7Or4G6TbPtQTl5qY1/YWY+Kyl3VRbACJNJvkyZ06 uG9V5EH7Styt8mO+k83MZIHM7u5cVz1N2VCYp00YrpgXjMqnxZDgHeKSqnitrqM7+xXJ Tv4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CsI29o49v7OzZiQnFoYh6md8pmnPwsYgrec/MYxjVew=; b=nyxbHkX+9fNng3L8jRSyLm0sgtufMoPVstQjyPu7QwCnVHgmvDo2Rmyy/e00hqks9X 4W+kLdrRc+DWs0jOpcsIPVhBL30c3ThemoJRhFXcQGv11GkZAR2MTr/LH4HhOT+XDlBo JuyGwxEzZvlIdR5deXJSP9i29Mt48yTbFisLXkNslIFjsPQPNa0XUDGs8dR0HFmL/ww8 kXyIfTGVPzXUtkJ86iTiIKmOuXvss/Qr0YFaShkXENlPXJEtE/YbBhdp2jKfeJ4bVm1v 7ptYuqyg9wjzj13RDAMZGHhy2mhx/5ShQ+K4YTqZyxOXbAIcHzzz/N6BsytBcDE8R3IN hPMw== X-Gm-Message-State: ACrzQf1DO1H/tU0wMnrDrQbvvdq+adoW/ZxJYm+RJlULmhHBgGaTnMJt 6Cdg4fmFuHUQHVXxEMbersFuRKfwZDIj1A== X-Google-Smtp-Source: AMsMyM4nGupMaHvU99+vbRmTfWyumVYazduN4ofWIt7ZYYz8M2mPyEoMMdk+xW6GcMpJJnnlviKw8A== X-Received: by 2002:a92:d685:0:b0:2ff:9abf:de49 with SMTP id p5-20020a92d685000000b002ff9abfde49mr11200505iln.42.1666733456724; Tue, 25 Oct 2022 14:30:56 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id c20-20020a02a614000000b0035a40af60fcsm1308057jam.86.2022.10.25.14.30.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Oct 2022 14:30:56 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 8A7368007FB; Tue, 25 Oct 2022 16:30:55 -0500 (CDT) Date: Tue, 25 Oct 2022 16:30:55 -0500 From: Justin Pryzby To: Thomas Munro Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix unlink() for STATUS_DELETE_PENDING on Windows. Message-ID: <20221025213055.GA8537@telsasoft.com> References: <20221025212102.GS16921@telsasoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221025212102.GS16921@telsasoft.com> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Oct 25, 2022 at 04:21:02PM -0500, Justin Pryzby wrote: > > Restore that behavior with an explicit check, to see if it fixes the > > occasional 'directory not empty' failures seen in the pg_upgrade tests > > on CI. Further improvements are possible with proposed upgrades to > > modern Windows APIs that would replace this convoluted code. > > > > Reported-by: Justin Pryzby > > Reviewed-by: Michael Paquier > > Discussion: https://postgr.es/m/20220920013122.GA31833%40telsasoft.com > > Discussion: https://postgr.es/m/CA%2BhUKG%2BajSQ_8eu2AogTncOnZ5me2D-Cn66iN_-wZnRjLN%2Bicg%40mail.gmail.com > ... > > Details > > ------- > > https://git.postgresql.org/pg/commitdiff/e109e43921d21d069c03f18d7c9d8f4e5cb6a0c3 > > If I'm not wrong, this didn't fix the issue you said it fixed. s/said/hoped/sorry