Date: Fri, 4 Nov 2022 11:19:35 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Resolve partition strategy during early parsing
Message-ID: <20221104161934.GB16921@telsasoft.com>
References: <E1oqcLs-000GqF-VN@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1oqcLs-000GqF-VN@gemulon.postgresql.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20221104161934.GB16921%40telsasoft.com>
Precedence: bulk

On Thu, Nov 03, 2022 at 03:41:56PM +0000, Alvaro Herrera wrote:
> Resolve partition strategy during early parsing
> 
> This has little practical value, but there's no reason to let the
> partition strategy names travel through DDL as strings.
> 
> Reviewed-by: Japin Li <japinli@hotmail.com>
> Discussion: https://postgr.es/m/20221021093216.ffupd7epy2mytkux@alvherre.pgsql
> 
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/5fca91025e05f803140831953c09a36f08efcef5

This caused a warning in MSVC.

[16:10:46.225] c:\cirrus\src\backend\parser\gram.y(18435) : warning C4715: 'parsePartitionStrategy': not all control paths return a value

I'll send a patch to make cfbot warn about that soon.